You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <iv...@visualsvn.com> on 2013/09/28 20:48:27 UTC
Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c
On 28 September 2013 22:20, <st...@apache.org> wrote:
> Author: stefan2
> Date: Sat Sep 28 18:20:00 2013
> New Revision: 1527211
>
> URL: http://svn.apache.org/r1527211
> Log:
> Hopefully, make our BSD buildbot happy.
>
> * subversion/svnserve/svnserve.c
> (serve_thread_t): say 'struct shared_pool_t' explicitly
>
What about "typedef struct shared_pool_t shared_pool_t" in .h file and
declare "struct shared_pool_t { ... } " in .c file? I found this
practice very useful for hide implementation in one module only.
--
Ivan Zhakov
Re: svn commit: r1527211 -
/subversion/trunk/subversion/svnserve/svnserve.c
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Sep 29, 2013 at 10:26:07AM +0200, Stefan Sperling wrote:
> On Sun, Sep 29, 2013 at 07:08:25AM +0200, Branko Čibej wrote:
> > The typedef is in an "#if APR_HAS_THREADS" block, the use in line 529 is
> > not. Apparently the APR is not compiled with thread support.
>
> Yes,and deliberately so. Because evidently nobody else does.
Should hopefully be fixed by r1527286 :)
Re: svn commit: r1527211 -
/subversion/trunk/subversion/svnserve/svnserve.c
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Sep 29, 2013 at 07:08:25AM +0200, Branko Čibej wrote:
> The typedef is in an "#if APR_HAS_THREADS" block, the use in line 529 is
> not. Apparently the APR is not compiled with thread support.
Yes,and deliberately so. Because evidently nobody else does.
Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c
Posted by Branko Čibej <br...@wandisco.com>.
On 28.09.2013 21:08, Stefan Fuhrmann wrote:
> On Sat, Sep 28, 2013 at 8:48 PM, Ivan Zhakov <ivan@visualsvn.com
> <ma...@visualsvn.com>> wrote:
>
> On 28 September 2013 22:20, <stefan2@apache.org
> <ma...@apache.org>> wrote:
> > Author: stefan2
> > Date: Sat Sep 28 18:20:00 2013
> > New Revision: 1527211
> >
> > URL: http://svn.apache.org/r1527211
> > Log:
> > Hopefully, make our BSD buildbot happy.
> >
> > * subversion/svnserve/svnserve.c
> > (serve_thread_t): say 'struct shared_pool_t' explicitly
> >
> What about "typedef struct shared_pool_t shared_pool_t" in .h file and
> declare "struct shared_pool_t { ... } " in .c file? I found this
> practice very useful for hide implementation in one module only.
>
>
> There is already a typedef for this in line 456 but the buildbot's GCC
> does not like it:
The typedef is in an "#if APR_HAS_THREADS" block, the use in line 529 is
not. Apparently the APR is not compiled with thread support.
I've always found that when "GCC doesn't like" code that looks perfectly
valid, it's a good idea to verify that the code is, in fact, valid.
Apparently it's not, this time.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com
Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 28 September 2013 23:08, Stefan Fuhrmann
<st...@wandisco.com> wrote:
> On Sat, Sep 28, 2013 at 8:48 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>>
>> On 28 September 2013 22:20, <st...@apache.org> wrote:
>> > Author: stefan2
>> > Date: Sat Sep 28 18:20:00 2013
>> > New Revision: 1527211
>> >
>> > URL: http://svn.apache.org/r1527211
>> > Log:
>> > Hopefully, make our BSD buildbot happy.
>> >
>> > * subversion/svnserve/svnserve.c
>> > (serve_thread_t): say 'struct shared_pool_t' explicitly
>> >
>> What about "typedef struct shared_pool_t shared_pool_t" in .h file and
>> declare "struct shared_pool_t { ... } " in .c file? I found this
>> practice very useful for hide implementation in one module only.
>
>
> There is already a typedef for this in line 456 but the buildbot's GCC
> does not like it:
>
Pretty strange. May be gcc will be happier if we define "struct
shared_pool_s {}" and "typedef struct shared_pool_s shared_pool_t" ?
--
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sat, Sep 28, 2013 at 8:48 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On 28 September 2013 22:20, <st...@apache.org> wrote:
> > Author: stefan2
> > Date: Sat Sep 28 18:20:00 2013
> > New Revision: 1527211
> >
> > URL: http://svn.apache.org/r1527211
> > Log:
> > Hopefully, make our BSD buildbot happy.
> >
> > * subversion/svnserve/svnserve.c
> > (serve_thread_t): say 'struct shared_pool_t' explicitly
> >
> What about "typedef struct shared_pool_t shared_pool_t" in .h file and
> declare "struct shared_pool_t { ... } " in .c file? I found this
> practice very useful for hide implementation in one module only.
>
There is already a typedef for this in line 456 but the buildbot's GCC
does not like it:
http://ci.apache.org/builders/bb-openbsd/builds/2748/steps/Build/logs/stdio
-- Stefan^2.