[jira] [Comment Edited] (PDFBOX-1684) DateConverter source is in three places and has diverged

["Fred Hansen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754095#comment-13754095 ] 

Fred Hansen edited comment on PDFBOX-1684 at 8/29/13 9:44 PM:
--------------------------------------------------------------

PDFBOX-1187 proposes swithing pdfbox to call xmpbox instead of jempbox. If we did this, then moving the supported version of DateConverter to xmpbox works well.   (or DateConverter could be in a separate module imported by both.)


                
      was (Author: zweibieren):
    If we stopsupport of jempbox and connect pdfbox to xmpbox, then moving the supported version of DateConverter to xmpbox works well.  


                  
> DateConverter source is in three places and has diverged
> --------------------------------------------------------
>
>                 Key: PDFBOX-1684
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1684
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0.0
>         Environment: Win 8, maven 3.0.5, svn 1.7.8 (r1419691), javac 1.7.0_25
>            Reporter: Fred Hansen
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Versions of DateConverter,java are in three (3) packages: jempbox.impl, pdfbox.util, and xmpbox. They have diverged as updates have been made to one or the other. 
> Date Converter is used in these modules:
>     jempbox.xmp.ResourceEvent.java
>     jempbox.xmp.XMPSchema.java
>     pdfbox.cos.COSDictionary.java
>     pdfbox.pdmodel.fdf.FDFAnnotation.java
>     preflight.metadata.SynchronizedMetaDataValidation.java
>     xmpbox.type.DateType.java
> The smallest library is xmpbox, so let's consider it as a home for DateConverter. Preflight already imports xmpbox. Pdfbox requires jempbox, so importing xmpbox into jempbox will satisfy both.  Since xmpbox defines some xmp features, it seems likely that jempbox could take further advantage of xmpbox.
> Conclusion and recommendation:  have a single copy of DateConverter in xmpbox.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira