[GitHub] [spark] s1ck commented on issue #24490: [SPARK-27300][GRAPH][test-maven] Add Spark Graph modules and dependencies

[GitBox <gi...@apache.org>]

s1ck commented on issue #24490: [SPARK-27300][GRAPH][test-maven] Add Spark Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-496421962
 
 
   @dongjoon-hyun We have successfully reduced the dependencies using a shaded jar including relocated dependencies. Please have a second look.
   @felixcheung The `META-INF` folder within the shaded jar lists all licenses (Apache 2.0 / MIT) and the libs that use them. Are there specific requirements where the license list should be stored?
   @mengxr The shaded jar has been produced solely using Gradle Shadow, we did not fix annotations with ScalaShade or any other tooling. Instead, we removed leaking references to relocated libraries from our APIs. This allows us to successfully compile and run spark-cypher tests. I can summarize the relocation story in another PR comment but would not involve the mailing list, as this is basically unblocked now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org