[GitHub] [pulsar] 315157973 commented on a change in pull request #7598: Support configuring DeleteInactiveTopic setting in namespace policy

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #7598:
URL: https://github.com/apache/pulsar/pull/7598#discussion_r458093542



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -98,8 +99,7 @@ public AbstractTopic(String topic, BrokerService brokerService) {
         this.producers = new ConcurrentHashMap<>();
         this.isFenced = false;
         this.replicatorPrefix = brokerService.pulsar().getConfiguration().getReplicatorPrefix();
-        this.deleteWhileInactive =
-                brokerService.pulsar().getConfiguration().isBrokerDeleteInactiveTopicsEnabled();
+        this.inactiveTopicPolicies.setDeleteWhileInactive(brokerService.pulsar().getConfiguration().isBrokerDeleteInactiveTopicsEnabled());

Review comment:
       I have fixed it. If there is a namespace level policy, the policy will be restored from zk in the subclass construction method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org