You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2008/06/12 15:56:32 UTC
svn commit: r667093 - in /geronimo/gshell/trunk:
gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java
Author: jdillon
Date: Thu Jun 12 06:56:32 2008
New Revision: 667093
URL: http://svn.apache.org/viewvc?rev=667093&view=rev
Log:
Drop the build() method, use ShellFactory's create() instead
Modified:
geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java
Modified: geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java?rev=667093&r1=667092&r2=667093&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java (original)
+++ geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java Thu Jun 12 06:56:32 2008
@@ -240,7 +240,7 @@
}
// Build the shell instance
- Shell gshell = builder.build();
+ Shell gshell = builder.create();
// clp gives us a list, but we need an array
String[] _args = commandArgs.toArray(new String[commandArgs.size()]);
Modified: geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java?rev=667093&r1=667092&r2=667093&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java (original)
+++ geronimo/gshell/trunk/gshell-plugin/src/main/java/org/apache/geronimo/gshell/builder/ShellBuilder.java Thu Jun 12 06:56:32 2008
@@ -190,10 +190,10 @@
}
//
- // Building
+ // ShellFactory
//
- public Shell build() throws Exception {
+ public Shell create() throws Exception {
log.debug("Building");
// Hijack the system output streams
@@ -223,8 +223,4 @@
return getApplicationManager().create();
}
-
- public Shell create() throws Exception {
- return build();
- }
}
\ No newline at end of file