You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/06 09:24:56 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
wu-sheng opened a new pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
To improve the performance to flush data into the database, and prepare the adoption to the native BanyanDB, I make `StorageBuilder` getting rid of `Map`.
In the stage 2, I will try to add features of providing override mechanism to builder. Although, this wouldn't be easy, because some metrics's builder are OAL generated, we can't override it manually. But provide a mechanism to support trace and log are much easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.15%`.
> The diff coverage is `47.88%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.53% -9.16%
+ Complexity 2781 1829 -952
============================================
Files 974 791 -183
Lines 24139 19470 -4669
Branches 2365 1838 -527
============================================
- Hits 9582 5946 -3636
+ Misses 13818 13101 -717
+ Partials 739 423 -316
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| ... and [438 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (da244a5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `2.10%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 41.80% +2.10%
+ Complexity 2781 2492 -289
============================================
Files 974 810 -164
Lines 24139 20221 -3918
Branches 2365 1929 -436
============================================
- Hits 9582 8453 -1129
+ Misses 13818 11115 -2703
+ Partials 739 653 -86
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `3.74%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 43.43% +3.74%
+ Complexity 2781 2585 -196
============================================
Files 974 810 -164
Lines 24139 20221 -3918
Branches 2365 1929 -436
============================================
- Hits 9582 8784 -798
+ Misses 13818 10770 -3048
+ Partials 739 667 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `5.64%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 45.33% +5.64%
+ Complexity 2781 2648 -133
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9174 -408
+ Misses 13818 10350 -3468
+ Partials 739 710 -29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `16.62%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 56.32% +16.62%
- Complexity 2781 3887 +1106
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13477 +3895
+ Misses 13818 9260 -4558
- Partials 739 1191 +452
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (f7a320b) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `5.88%`.
> The diff coverage is `92.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 45.58% +5.88%
+ Complexity 2781 445 -2336
============================================
Files 974 1741 +767
Lines 24139 36980 +12841
Branches 2365 4766 +2401
============================================
+ Hits 9582 16857 +7275
- Misses 13818 19136 +5318
- Partials 739 987 +248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `62.91% <ø> (-0.27%)` | `2.00 <0.00> (-27.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-1.00)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `1.00 <0.00> (-1.00)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `1.00 <0.00> (-2.00)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `0.00 <0.00> (-11.00)` | |
| [.../plugin/elasticsearch7/query/AlarmQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BbGFybVF1ZXJ5RXM3REFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/influxdb/query/NetworkAddressAliasDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9OZXR3b3JrQWRkcmVzc0FsaWFzREFPLmphdmE=) | `41.37% <0.00%> (ø)` | `0.00 <0.00> (-3.00)` | |
| [...e/plugin/jdbc/h2/dao/AbstractSearchTagBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0Fic3RyYWN0U2VhcmNoVGFnQnVpbGRlci5qYXZh) | `64.28% <ø> (ø)` | `0.00 <0.00> (-3.00)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (f7a320b) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `10.36%`.
> The diff coverage is `8.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
- Coverage 39.69% 29.32% -10.37%
=============================================
Files 974 1654 +680
Lines 24139 34730 +10591
Branches 2365 4602 +2237
=============================================
+ Hits 9582 10185 +603
- Misses 13818 23598 +9780
- Partials 739 947 +208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <ø> (-63.18%)` | `0.00 <0.00> (-29.00)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (-4.35%)` | `0.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-1.00)` | |
| [...nalysis/manual/database/TopNDatabaseStatement.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL1RvcE5EYXRhYmFzZVN0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (-4.17%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `68.96% <0.00%> (+6.89%)` | `0.00 <0.00> (-5.00)` | :arrow_up: |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `0.00% <0.00%> (-54.00%)` | `0.00 <0.00> (-6.00)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (-1.00)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-2.00)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `0.00% <0.00%> (-2.44%)` | `0.00 <0.00> (ø)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-75.00%)` | `0.00 <0.00> (-7.00)` | |
| ... and [1724 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (ccfe326) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `6.56%`.
> The diff coverage is `50.70%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 33.13% -6.57%
+ Complexity 2781 1946 -835
============================================
Files 974 791 -183
Lines 24139 19531 -4608
Branches 2365 1843 -522
============================================
- Hits 9582 6471 -3111
+ Misses 13818 12603 -1215
+ Partials 739 457 -282
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [411 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (f7a320b) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `5.76%`.
> The diff coverage is `92.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 45.45% +5.76%
+ Complexity 2781 444 -2337
============================================
Files 974 1741 +767
Lines 24139 36980 +12841
Branches 2365 4766 +2401
============================================
+ Hits 9582 16810 +7228
- Misses 13818 19183 +5365
- Partials 739 987 +248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `62.91% <ø> (-0.27%)` | `2.00 <0.00> (-27.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-1.00)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `1.00 <0.00> (-1.00)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `1.00 <0.00> (-2.00)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `0.00 <0.00> (-11.00)` | |
| [.../plugin/elasticsearch7/query/AlarmQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BbGFybVF1ZXJ5RXM3REFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/influxdb/query/NetworkAddressAliasDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9OZXR3b3JrQWRkcmVzc0FsaWFzREFPLmphdmE=) | `41.37% <0.00%> (ø)` | `0.00 <0.00> (-3.00)` | |
| [...e/plugin/jdbc/h2/dao/AbstractSearchTagBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0Fic3RyYWN0U2VhcmNoVGFnQnVpbGRlci5qYXZh) | `64.28% <ø> (ø)` | `0.00 <0.00> (-3.00)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `16.87%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 56.56% +16.87%
- Complexity 2781 3898 +1117
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13535 +3953
+ Misses 13818 9192 -4626
- Partials 739 1201 +462
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8cd358f) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.08%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.60% -9.09%
+ Complexity 2781 1928 -853
============================================
Files 974 808 -166
Lines 24139 20067 -4072
Branches 2365 1916 -449
============================================
- Hits 9582 6142 -3440
+ Misses 13818 13455 -363
+ Partials 739 470 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00 <0.00> (-1.00)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...916b9f1](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `2.94%`.
> The diff coverage is `65.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 36.74% -2.95%
+ Complexity 2781 2192 -589
============================================
Files 974 792 -182
Lines 24139 19646 -4493
Branches 2365 1872 -493
============================================
- Hits 9582 7219 -2363
+ Misses 13818 11877 -1941
+ Partials 739 550 -189
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `13.14%`.
> The diff coverage is `47.88%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
- Coverage 39.69% 26.55% -13.15%
+ Complexity 2781 1652 -1129
=============================================
Files 974 791 -183
Lines 24139 19371 -4768
Branches 2365 1807 -558
=============================================
- Hits 9582 5143 -4439
- Misses 13818 13857 +39
+ Partials 739 371 -368
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| ... and [480 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `15.62%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 55.32% +15.62%
- Complexity 2781 3835 +1054
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13237 +3655
+ Misses 13818 9534 -4284
- Partials 739 1157 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.20%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.89% +1.20%
+ Complexity 2781 2454 -327
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8260 -1322
+ Misses 13818 11298 -2520
+ Partials 739 640 -99
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#discussion_r571399570
##########
File path: CHANGES.md
##########
@@ -17,6 +17,7 @@ Release Notes.
* Metrics combination API supports abandoning results.
* Add a new concept "Event" and its implementations to collect events.
* Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace.
+* Refactor StorageBuilder to remove the dependency of Map.
Review comment:
Let me remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#discussion_r571393634
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/type/StorageBuilder.java
##########
@@ -16,18 +16,16 @@
*
*/
-package org.apache.skywalking.oap.server.core.storage;
-
-import java.util.Map;
+package org.apache.skywalking.oap.server.core.storage.type;
/**
- * Converter between the give T and Map.
+ * Converter between the give T and K.
*
* @param <T> A storage entity implementation.
+ * @param <K> The data structure recognized by the storage implementation.
*/
-public interface StorageBuilder<T extends StorageData> {
-
- T map2Data(Map<String, Object> dbMap);
+public interface StorageBuilder<T, K> {
+ T storage2Entity(K dbMap);
Review comment:
Also get rid of the map at interface definition?
```suggestion
T storage2Entity(K storageData);
```
##########
File path: CHANGES.md
##########
@@ -17,6 +17,7 @@ Release Notes.
* Metrics combination API supports abandoning results.
* Add a new concept "Event" and its implementations to collect events.
* Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace.
+* Refactor StorageBuilder to remove the dependency of Map.
Review comment:
I've been thinking whether we should include (nearly) all kinds of changes here, IMO the changes is targeted to our end users, who don't care about our code lever refactor at all, as well as some chores like CI settings, etc.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/type/StorageBuilder.java
##########
@@ -16,18 +16,16 @@
*
*/
-package org.apache.skywalking.oap.server.core.storage;
-
-import java.util.Map;
+package org.apache.skywalking.oap.server.core.storage.type;
/**
- * Converter between the give T and Map.
+ * Converter between the give T and K.
*
* @param <T> A storage entity implementation.
+ * @param <K> The data structure recognized by the storage implementation.
*/
-public interface StorageBuilder<T extends StorageData> {
-
- T map2Data(Map<String, Object> dbMap);
+public interface StorageBuilder<T, K> {
+ T storage2Entity(K dbMap);
- Map<String, Object> data2Map(T storageData);
+ K entity2Storage(T storageData);
Review comment:
```suggestion
K entity2Storage(T entity);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (ccfe326) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `3.48%`.
> The diff coverage is `67.60%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 36.20% -3.49%
+ Complexity 2781 2098 -683
============================================
Files 974 791 -183
Lines 24139 19531 -4608
Branches 2365 1843 -522
============================================
- Hits 9582 7072 -2510
+ Misses 13818 11945 -1873
+ Partials 739 514 -225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [394 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `5.88%`.
> The diff coverage is `75.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 45.58% +5.88%
+ Complexity 2781 2724 -57
============================================
Files 974 810 -164
Lines 24139 20247 -3892
Branches 2365 1947 -418
============================================
- Hits 9582 9229 -353
+ Misses 13818 10282 -3536
+ Partials 739 736 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [318 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.85%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.55% +6.85%
+ Complexity 2781 2684 -97
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9419 -163
+ Misses 13818 10070 -3748
- Partials 739 745 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `12.36%`.
> The diff coverage is `47.88%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
- Coverage 39.69% 27.32% -12.37%
+ Complexity 2781 1696 -1085
=============================================
Files 974 791 -183
Lines 24139 19371 -4768
Branches 2365 1807 -558
=============================================
- Hits 9582 5294 -4288
+ Misses 13818 13706 -112
+ Partials 739 371 -368
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `5.20%`.
> The diff coverage is `75.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 44.90% +5.20%
+ Complexity 2781 2677 -104
============================================
Files 974 810 -164
Lines 24139 20236 -3903
Branches 2365 1930 -435
============================================
- Hits 9582 9086 -496
+ Misses 13818 10418 -3400
+ Partials 739 732 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `0.80%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.49% +0.80%
+ Complexity 2781 2442 -339
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8180 -1402
+ Misses 13818 11393 -2425
+ Partials 739 625 -114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (e5de4e0) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `10.36%`.
> The diff coverage is `8.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
- Coverage 39.69% 29.32% -10.37%
=============================================
Files 974 1654 +680
Lines 24139 34730 +10591
Branches 2365 4602 +2237
=============================================
+ Hits 9582 10185 +603
- Misses 13818 23598 +9780
- Partials 739 947 +208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <ø> (-63.18%)` | `0.00 <0.00> (-29.00)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (-4.35%)` | `0.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-1.00)` | |
| [...nalysis/manual/database/TopNDatabaseStatement.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL1RvcE5EYXRhYmFzZVN0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (-4.17%)` | `0.00 <0.00> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `68.96% <0.00%> (+6.89%)` | `0.00 <0.00> (-5.00)` | :arrow_up: |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `0.00% <0.00%> (-54.00%)` | `0.00 <0.00> (-6.00)` | |
| [...er/core/analysis/manual/log/AbstractLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9BYnN0cmFjdExvZ1JlY29yZC5qYXZh) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (-1.00)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-2.00)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `0.00% <0.00%> (-2.44%)` | `0.00 <0.00> (ø)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-75.00%)` | `0.00 <0.00> (-7.00)` | |
| ... and [1724 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `3.03%`.
> The diff coverage is `65.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 42.73% +3.03%
+ Complexity 2781 2497 -284
============================================
Files 974 792 -182
Lines 24139 19684 -4455
Branches 2365 1874 -491
============================================
- Hits 9582 8411 -1171
+ Misses 13818 10595 -3223
+ Partials 739 678 -61
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.39%`.
> The diff coverage is `75.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.08% +6.39%
+ Complexity 2781 2736 -45
============================================
Files 974 810 -164
Lines 24139 20247 -3892
Branches 2365 1947 -418
============================================
- Hits 9582 9331 -251
+ Misses 13818 10170 -3648
- Partials 739 746 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [318 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8cd358f) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.08%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.60% -9.09%
+ Complexity 2781 1928 -853
============================================
Files 974 808 -166
Lines 24139 20067 -4072
Branches 2365 1916 -449
============================================
- Hits 9582 6142 -3440
+ Misses 13818 13455 -363
+ Partials 739 470 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00 <0.00> (-1.00)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...ae67c37](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.58%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.28% +6.58%
+ Complexity 2781 2680 -101
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9365 -217
+ Misses 13818 10139 -3679
+ Partials 739 730 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `15.93%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 55.63% +15.93%
- Complexity 2781 3844 +1063
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13312 +3730
+ Misses 13818 9440 -4378
- Partials 739 1176 +437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `10.56%`.
> The diff coverage is `82.05%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 50.26% +10.56%
- Complexity 2781 3588 +807
=============================================
Files 974 960 -14
Lines 24139 23847 -292
Branches 2365 2354 -11
=============================================
+ Hits 9582 11986 +2404
+ Misses 13818 10801 -3017
- Partials 739 1060 +321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8cd358f) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.08%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.60% -9.09%
+ Complexity 2781 1928 -853
============================================
Files 974 808 -166
Lines 24139 20067 -4072
Branches 2365 1916 -449
============================================
- Hits 9582 6142 -3440
+ Misses 13818 13455 -363
+ Partials 739 470 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00 <0.00> (-1.00)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `8.90%`.
> The diff coverage is `47.88%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.79% -8.91%
+ Complexity 2781 1845 -936
============================================
Files 974 792 -182
Lines 24139 19505 -4634
Branches 2365 1842 -523
============================================
- Hits 9582 6006 -3576
+ Misses 13818 13078 -740
+ Partials 739 421 -318
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| ... and [436 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `0.79%`.
> The diff coverage is `80.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.49% +0.79%
+ Complexity 2781 2389 -392
============================================
Files 974 792 -182
Lines 24139 19693 -4446
Branches 2365 1876 -489
============================================
- Hits 9582 7974 -1608
+ Misses 13818 11109 -2709
+ Partials 739 610 -129
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.87%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.56% +6.87%
+ Complexity 2781 2686 -95
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9422 -160
+ Misses 13818 10067 -3751
- Partials 739 745 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `0.45%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.15% +0.45%
+ Complexity 2781 2426 -355
============================================
Files 974 810 -164
Lines 24139 20185 -3954
Branches 2365 1928 -437
============================================
- Hits 9582 8105 -1477
+ Misses 13818 11468 -2350
+ Partials 739 612 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [335 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `11.96%`.
> The diff coverage is `48.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
- Coverage 39.69% 27.72% -11.97%
+ Complexity 2781 1724 -1057
=============================================
Files 974 791 -183
Lines 24139 19564 -4575
Branches 2365 1865 -500
=============================================
- Hits 9582 5425 -4157
+ Misses 13818 13742 -76
+ Partials 739 397 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [483 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `15.61%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 55.31% +15.61%
- Complexity 2781 3834 +1053
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13235 +3653
+ Misses 13818 9535 -4283
- Partials 739 1158 +419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `4.23%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 43.92% +4.23%
+ Complexity 2781 2608 -173
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 8888 -694
+ Misses 13818 10667 -3151
+ Partials 739 679 -60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `13.54%`.
> The diff coverage is `85.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 53.24% +13.54%
- Complexity 2781 3745 +964
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 12740 +3158
+ Misses 13818 10052 -3766
- Partials 739 1136 +397
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [331 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `11.53%`.
> The diff coverage is `85.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 51.23% +11.53%
- Complexity 2781 3642 +861
=============================================
Files 974 961 -13
Lines 24139 23892 -247
Branches 2365 2358 -7
=============================================
+ Hits 9582 12241 +2659
+ Misses 13818 10561 -3257
- Partials 739 1090 +351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `4.63%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 44.32% +4.63%
+ Complexity 2781 2620 -161
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 8969 -613
+ Misses 13818 10571 -3247
+ Partials 739 694 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [330 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (f7a320b) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `4.19%`.
> The diff coverage is `74.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 43.88% +4.19%
+ Complexity 2781 422 -2359
============================================
Files 974 1741 +767
Lines 24139 36980 +12841
Branches 2365 4766 +2401
============================================
+ Hits 9582 16230 +6648
- Misses 13818 19762 +5944
- Partials 739 988 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `62.91% <ø> (-0.27%)` | `2.00 <0.00> (-27.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-1.00)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `1.00 <0.00> (-1.00)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `1.00 <0.00> (-2.00)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `0.00 <0.00> (-11.00)` | |
| [.../plugin/elasticsearch7/query/AlarmQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BbGFybVF1ZXJ5RXM3REFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-6.00)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `17.17%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 56.87% +17.17%
- Complexity 2781 3916 +1135
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13609 +4027
+ Misses 13818 9120 -4698
- Partials 739 1199 +460
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.02%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.71% +1.02%
+ Complexity 2781 2448 -333
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8224 -1358
+ Misses 13818 11341 -2477
+ Partials 739 633 -106
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8cd358f) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.08%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.60% -9.09%
+ Complexity 2781 1928 -853
============================================
Files 974 808 -166
Lines 24139 20067 -4072
Branches 2365 1916 -449
============================================
- Hits 9582 6142 -3440
+ Misses 13818 13455 -363
+ Partials 739 470 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00 <0.00> (-1.00)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...a916f8d](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.23%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.93% +1.23%
+ Complexity 2781 2455 -326
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8268 -1314
+ Misses 13818 11290 -2528
+ Partials 739 640 -99
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (da244a5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.21%`.
> The diff coverage is `78.20%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.90% +1.21%
+ Complexity 2781 2455 -326
============================================
Files 974 810 -164
Lines 24139 20221 -3918
Branches 2365 1929 -436
============================================
- Hits 9582 8272 -1310
+ Misses 13818 11314 -2504
+ Partials 739 635 -104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [326 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `2.21%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 41.90% +2.21%
+ Complexity 2781 2511 -270
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8464 -1118
+ Misses 13818 11084 -2734
+ Partials 739 650 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [353 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.89%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 41.59% +1.89%
+ Complexity 2781 2495 -286
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8401 -1181
+ Misses 13818 11150 -2668
+ Partials 739 647 -92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [353 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.35%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.05% +6.35%
+ Complexity 2781 2670 -111
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9318 -264
+ Misses 13818 10196 -3622
+ Partials 739 720 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#discussion_r571398440
##########
File path: CHANGES.md
##########
@@ -17,6 +17,7 @@ Release Notes.
* Metrics combination API supports abandoning results.
* Add a new concept "Event" and its implementations to collect events.
* Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace.
+* Refactor StorageBuilder to remove the dependency of Map.
Review comment:
I am not sure either. I just want to make this kind of change clear to all developer. Do you want me to remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (da244a5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `5.39%`.
> The diff coverage is `48.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 34.29% -5.40%
+ Complexity 2781 2065 -716
============================================
Files 974 792 -182
Lines 24139 19646 -4493
Branches 2365 1872 -493
============================================
- Hits 9582 6738 -2844
+ Misses 13818 12405 -1413
+ Partials 739 503 -236
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [394 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (ccfe326) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `0.04%`.
> The diff coverage is `84.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 39.74% +0.04%
+ Complexity 2781 2253 -528
============================================
Files 974 791 -183
Lines 24139 19540 -4599
Branches 2365 1843 -522
============================================
- Hits 9582 7766 -1816
+ Misses 13818 11213 -2605
+ Partials 739 561 -178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <ø> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `15.85%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 55.55% +15.85%
- Complexity 2781 3842 +1061
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13293 +3711
+ Misses 13818 9460 -4358
- Partials 739 1175 +436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8cd358f) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `9.08%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 30.60% -9.09%
+ Complexity 2781 1928 -853
============================================
Files 974 808 -166
Lines 24139 20067 -4072
Branches 2365 1916 -449
============================================
- Hits 9582 6142 -3440
+ Misses 13818 13455 -363
+ Partials 739 470 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00 <0.00> (-1.00)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.87%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.56% +6.87%
+ Complexity 2781 2686 -95
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9422 -160
+ Misses 13818 10067 -3751
- Partials 739 745 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.03%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.73% +1.03%
+ Complexity 2781 2450 -331
============================================
Files 974 810 -164
Lines 24139 20198 -3941
Branches 2365 1928 -437
============================================
- Hits 9582 8227 -1355
+ Misses 13818 11338 -2480
+ Partials 739 633 -106
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **decrease** coverage by `5.34%`.
> The diff coverage is `48.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
- Coverage 39.69% 34.35% -5.35%
+ Complexity 2781 2067 -714
============================================
Files 974 792 -182
Lines 24139 19646 -4493
Branches 2365 1872 -493
============================================
- Hits 9582 6749 -2833
+ Misses 13818 12393 -1425
+ Partials 739 504 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/ManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYW5hZ2VtZW50RXNEQU8uamF2YQ==) | `0.00% <0.00%> (-81.82%)` | `0.00 <0.00> (-2.00)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `14.98%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 54.68% +14.98%
- Complexity 2781 3811 +1030
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13084 +3502
+ Misses 13818 9689 -4129
- Partials 739 1155 +416
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (8c0df7c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `2.89%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 42.59% +2.89%
+ Complexity 2781 2536 -245
============================================
Files 974 810 -164
Lines 24139 20221 -3918
Branches 2365 1929 -436
============================================
- Hits 9582 8613 -969
+ Misses 13818 10953 -2865
+ Partials 739 655 -84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...8cd358f](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `14.40%`.
> The diff coverage is `92.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 54.09% +14.40%
- Complexity 2781 3788 +1007
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 12944 +3362
+ Misses 13818 9828 -3990
- Partials 739 1156 +417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [324 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (33a80b5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `15.90%`.
> The diff coverage is `94.87%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
=============================================
+ Coverage 39.69% 55.60% +15.90%
- Complexity 2781 3843 +1062
=============================================
Files 974 961 -13
Lines 24139 23928 -211
Branches 2365 2359 -6
=============================================
+ Hits 9582 13304 +3722
+ Misses 13818 9448 -4370
- Partials 739 1176 +437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...f7a320b](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (da244a5) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `1.05%`.
> The diff coverage is `78.20%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 40.75% +1.05%
+ Complexity 2781 2451 -330
============================================
Files 974 810 -164
Lines 24139 20221 -3918
Branches 2365 1929 -436
============================================
- Hits 9582 8241 -1341
+ Misses 13818 11356 -2462
+ Partials 739 624 -115
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-5.00)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#issuecomment-774433968
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=h1) Report
> Merging [#6334](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=desc) (928194c) into [master](https://codecov.io/gh/apache/skywalking/commit/5445b7d53f1b22b88c5770130f3c97b8855bf17e?el=desc) (5445b7d) will **increase** coverage by `6.73%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 39.69% 46.42% +6.73%
+ Complexity 2781 2680 -101
============================================
Files 974 810 -164
Lines 24139 20234 -3905
Branches 2365 1929 -436
============================================
- Hits 9582 9394 -188
+ Misses 13818 10105 -3713
+ Partials 739 735 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (ø)` | `29.00 <0.00> (ø)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWxhcm1RdWVyeUVzREFPLmphdmE=) | `7.40% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=footer). Last update [5445b7d...e5de4e0](https://codecov.io/gh/apache/skywalking/pull/6334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org