You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/02 18:05:42 UTC

[GitHub] [lucene] cpoerschke opened a new pull request #202: LUCENE-8638: remove deprecated WordDelimiterFilter[Factory] classes

cpoerschke opened a new pull request #202:
URL: https://github.com/apache/lucene/pull/202


   https://issues.apache.org/jira/browse/LUCENE-8638
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] cpoerschke commented on pull request #202: LUCENE-8638: remove deprecated WordDelimiterFilter[Factory] classes

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #202:
URL: https://github.com/apache/lucene/pull/202#issuecomment-873173511


   > And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?
   
   Ah, there's already https://issues.apache.org/jira/browse/LUCENE-8682 with a patch which includes Solr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] cpoerschke commented on pull request #202: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #202:
URL: https://github.com/apache/lucene/pull/202#issuecomment-877709067


   Thanks @msokolov for copying across the comments from the JIRA! I'll convert the pull request to "draft" to indicate the status of the deprecation process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] cpoerschke commented on pull request #202: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #202:
URL: https://github.com/apache/lucene/pull/202#issuecomment-873391686


   > > And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?
   > 
   > Ah, there's already https://issues.apache.org/jira/browse/LUCENE-8682 with a patch which includes Solr.
   
   https://github.com/apache/solr/pull/200 created with the LUCENE-8682 patch as its starting point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] cpoerschke commented on a change in pull request #202: LUCENE-8638, LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #202:
URL: https://github.com/apache/lucene/pull/202#discussion_r663192060



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestBugInSomething.java
##########
@@ -292,14 +292,13 @@ public void testCuriousWikipediaString() throws Exception {
           115, -105, 97, 65, -33, 57, 44, -1, 123, -68, 100, 13, -41, -64, -119, 0, 92, 94, -36, 53,
           -9, -102, -18, 90, 94, -26, 31, 71, -20
         };
-    @SuppressWarnings("deprecation")
     Analyzer a =
         new Analyzer() {
           @Override
           protected TokenStreamComponents createComponents(String fieldName) {
             Tokenizer tokenizer = new WikipediaTokenizer();
             TokenStream stream = new SopTokenFilter(tokenizer);
-            stream = new WordDelimiterFilter(stream, table, -50, protWords);

Review comment:
       `WordDelimiterGraphFilter` rejects the `-50` and it's not yet clear to me how convert it to something other than `0`. The -50 dates back to https://github.com/apache/lucene/commit/395c85e54a5848acbfbe63e1c71576c7c7113687#diff-7dd7bf9e8b9993f185f524bee479246dd99b451a796dc0c18ff2361577de1bd6 in 2014.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] cpoerschke commented on pull request #202: LUCENE-8638: remove deprecated WordDelimiterFilter[Factory] classes

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #202:
URL: https://github.com/apache/lucene/pull/202#issuecomment-873171067


   And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org