You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/04 09:23:22 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #26010: [WIP][SPARK-29342][SQL] Make casting of string values to intervals case insensitive

MaxGekk commented on a change in pull request #26010: [WIP][SPARK-29342][SQL] Make casting of string values to intervals case insensitive
URL: https://github.com/apache/spark/pull/26010#discussion_r331413684
 
 

 ##########
 File path: common/unsafe/src/test/java/org/apache/spark/unsafe/types/CalendarIntervalSuite.java
 ##########
 @@ -274,4 +249,23 @@ private static void testSingleUnit(String unit, int number, int months, long mic
     assertEquals(fromString(input1), result);
     assertEquals(fromString(input2), result);
   }
+
+  @Test
+  public void fromStringCaseSensitivityTest() {
 
 Review comment:
   What kind of negative test do you want to see?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org