[GitHub] [spark] grundprinzip commented on pull request #38037: [SPARK-40537][CONNECT] Enable mypy for Spark Connect Python Client

[GitBox <gi...@apache.org>]

grundprinzip commented on PR #38037:
URL: https://github.com/apache/spark/pull/38037#issuecomment-1264719567

   > > @zero323 if you find some time to take a look.
   > 
   > Thanks @HyukjinKwon Excluding the comments, it looks reasonable, though I am not familiar with design. I'll try to take another look in the upcoming days.
   
   @zero323 Thanks a lot for the reviews! Right now, the goal of this PR is to enable the mypy checks again so that going forward we make changes without breaking them again. There are no other functional changes to the Spark Connect interfaces.
   
   We will evolve the underlying implementation of the Spark Connect Python client over time. If you have suggestion please let us know, but please keep in mind that this is not the final implementation or final change for the client and interface package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org