You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by boivie <gi...@git.apache.org> on 2017/08/01 05:45:20 UTC
[GitHub] thrift pull request #1322: THRIFT-4246 Multiplexed clients sequence id fix
GitHub user boivie opened a pull request:
https://github.com/apache/thrift/pull/1322
THRIFT-4246 Multiplexed clients sequence id fix
Client: nodejs
Previously, all clients would use the latest created multiplexer
for generating sequence numbers which would create a mismatch
between the mapping of sequence number->service in the connection.
This makes the client instances use the multiplexer that is
bound to it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/boivie/thrift seq-id-mismatch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1322
----
commit 91369aebfc5ca910cdd3871ee59de7a1e8244b6f
Author: Victor Boivie <vi...@boivie.com>
Date: 2017-07-08T11:21:55Z
THRIFT-4246 Multiplexed clients sequence id fix
Client: nodejs
Previously, all clients would use the latest created multiplexer
for generating sequence numbers which would create a mismatch
between the mapping of sequence number->service in the connection.
This makes the client instances use the multiplexer that is
bound to it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1322: THRIFT-4246 Multiplexed clients sequence id fix
Posted by boivie <gi...@git.apache.org>.
Github user boivie commented on the issue:
https://github.com/apache/thrift/pull/1322
@jeking3 The CI tests fails every time for seemingly unrelated reasons.
I won't try to solve that.
It's up to you now if you want to bring this one in. I have converted my project to gRPC for several reasons, so I'm not committed in this bugfix any longer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1322: THRIFT-4246 Multiplexed clients sequence id fix
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1322
Hmm, well I tried to rebase this on master and push it back into your branch so it would build again but I cannot - no permission. So, I'm running cross test in the xenial docker image locally and if it passes I will merge it into master.
---
[GitHub] thrift pull request #1322: THRIFT-4246 Multiplexed clients sequence id fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1322
---
[GitHub] thrift issue #1322: THRIFT-4246 Multiplexed clients sequence id fix
Posted by boivie <gi...@git.apache.org>.
Github user boivie commented on the issue:
https://github.com/apache/thrift/pull/1322
Thanks James. I just rebased it, but travis and AppVeyor fails from unrelated reasons. Can they be retriggered?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---