You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by qqeasonchen <gi...@git.apache.org> on 2017/07/26 10:24:59 UTC
[GitHub] incubator-rocketmq pull request #136: [ROCKETMQ-242] mqclient can not fetch ...
GitHub user qqeasonchen opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/136
[ROCKETMQ-242] mqclient can not fetch nameSrvAddr periodly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qqeasonchen/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit bf213c5ec8ab529678fcd694be9d24f099639328
Author: easoncchen <da...@qq.com>
Date: 2017-07-26T10:20:43Z
[ROCKETMQ-242] mqclient can not fetch nameSrvAddr periodly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
[](https://coveralls.io/builds/12556621)
Coverage decreased (-0.7%) to 38.433% when pulling **ffff63704577e51534a7f793d5c13b23cd91c188 on qqeasonchen:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
[](https://coveralls.io/builds/12589394)
Coverage decreased (-0.2%) to 38.519% when pulling **e66236ee5fbfb03426b7b4da6d663f1f8984f933 on qqeasonchen:master** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
[](https://coveralls.io/builds/12556621)
Coverage decreased (-0.7%) to 38.433% when pulling **ffff63704577e51534a7f793d5c13b23cd91c188 on qqeasonchen:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
Any description about this PR ? Or, you could add the jira link.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
Then you probably don't need this code
```
if (null == this.clientConfig.getNamesrvAddr()) {
this.mQClientAPIImpl.fetchNameServerAddr();
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #136: [ROCKETMQ-242] mqclient can not fetch ...
Posted by qqeasonchen <gi...@git.apache.org>.
Github user qqeasonchen closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
[](https://coveralls.io/builds/12555899)
Coverage decreased (-0.5%) to 38.646% when pulling **bf213c5ec8ab529678fcd694be9d24f099639328 on qqeasonchen:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
[](https://coveralls.io/builds/12555899)
Coverage decreased (-0.5%) to 38.646% when pulling **bf213c5ec8ab529678fcd694be9d24f099639328 on qqeasonchen:master** into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #136: [ROCKETMQ-242] mqclient can not fetch nameSrv...
Posted by qqeasonchen <gi...@git.apache.org>.
Github user qqeasonchen commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/136
if (null == this.clientConfig.getNamesrvAddr()) {
this.mQClientAPIImpl.fetchNameServerAddr();
}
@shroman this code still useful when init, and i will move to develop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---