You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "tballison (via GitHub)" <gi...@apache.org> on 2024/10/11 11:55:45 UTC
[PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
tballison opened a new pull request, #1976:
URL: https://github.com/apache/tika/pull/1976
…elimiters
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr merged PR #1976:
URL: https://github.com/apache/tika/pull/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1976:
URL: https://github.com/apache/tika/pull/1976#issuecomment-2407325929
I see you removed the "colon isn't reliable" code part. Did you test what would happen with the file mentioned in that code segment (242970.txt)? IMHO the colon should still be "discriminated" if others have the same confidence.
I'm currently trying to build and modified version and will then run a regression test on the csv fileset (this is faster than running the build itself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1976:
URL: https://github.com/apache/tika/pull/1976#issuecomment-2407819859
I forgot to mention, the test with the file mentioned works nicely! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #1976:
URL: https://github.com/apache/tika/pull/1976#issuecomment-2407368869
Y, I figured that if someone turned on the colon detection, that was their choice. I'm happy to put that logic back in. If we do so, I'd like to modify it slightly so that we check a tiny delta rather than an == on the diff between first and second place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4278 -- remove colon from default and allow users to customize d… [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #1976:
URL: https://github.com/apache/tika/pull/1976#issuecomment-2407374002
I put the check back in. Let me know what you find. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org