[jira] [Comment Edited] (LOG4NET-472) Contribution of BurstFilter

["Dominik Psenner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4NET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710266#comment-14710266 ] 

Dominik Psenner edited comment on LOG4NET-472 at 8/24/15 11:27 PM:
-------------------------------------------------------------------

Hi there,

thanks! I gave your code a quick review and found some notable things that will have to be improved before this goes to log4net core and because you are using this in a production environment I would like to share these ideas with you:

* DateTime.UtcNow reports the current computers datetime. You should probably use the LoggingEvent's Timestamp to prevent race conditions.
* I expected a leaky bucket algorithm, but your implementation is somewhat different and probably does not behave like you want it to when there are constantly too many log events generated. For instance it will no longer send log events at all as long as the rate at which log events are generated does not drop back to normal.

Cheers


was (Author: nachbarslumpi):
Hi there,

thanks! I gave your code a quick review and found some notable things that will have to be improved before this goes to log4net core and because you are using this in a production environment I would like to share these ideas with you:

* DateTime.UtcNow reports the current computers datetime. You should probably use the LoggingEvent's Timestamp.
* I expected a leaky bucket algorithm, but your implementation is somewhat different and probably does not behave like you want it to when there are constantly too many log events generated. For instance it will no longer send log events at all as long as the rate at which log events are generated does not drop back to normal.

Cheers

> Contribution of BurstFilter
> ---------------------------
>
>                 Key: LOG4NET-472
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-472
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Other
>    Affects Versions: 1.2.13
>            Reporter: Albin Sunnanbo
>            Priority: Minor
>
> Hi
> I wrote a BurstFilter implementation for Log4net a while ago, trying to mimic the API of BurstFilter for Log4j https://logging.apache.org/log4j/2.0/log4j-core/apidocs/org/apache/logging/log4j/core/filter/BurstFilter.html
> I have published my source code on our company GitHub account: 
> https://github.com/KentorIT/Log4NetExtensions
> But I would of course be happy to contribute the extension back to the main project on apache.org.
> Would a contribution be accepted and in such case how would you like the contribution served? As a diff in this Jira issue?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)