You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/06 21:03:51 UTC
[GitHub] [tvm] Lunderberg opened a new pull request #7997: [Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit
Lunderberg opened a new pull request #7997:
URL: https://github.com/apache/tvm/pull/7997
Most of the TVM Global() functions allocate with "new" and do not deallocate, as the OS can clean up any leftover buffers at the end. In this case, we need the VulkanDeviceAPI destructor to call vkDestroyInstance, to prevent a sporadic segfault on exit when using some nvidia drivers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #7997: [Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #7997:
URL: https://github.com/apache/tvm/pull/7997#issuecomment-833865234
Potential reviewers: @tqchen @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7997: [Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7997:
URL: https://github.com/apache/tvm/pull/7997#issuecomment-837392149
@Lunderberg please try running the CI again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7997: [Bugfix][Vulkan] Call VulkanDeviceAPI destructor on program exit
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7997:
URL: https://github.com/apache/tvm/pull/7997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org