You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/12/04 15:45:35 UTC
[GitHub] [commons-bcel] nbauma109 opened a new pull request, #180: verifier tests on various opcodes
nbauma109 opened a new pull request, #180:
URL: https://github.com/apache/commons-bcel/pull/180
- fixed typo testCommonsLang1->2
- test of various opcodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #180: verifier tests on various opcodes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #180:
URL: https://github.com/apache/commons-bcel/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #180: verifier tests on various opcodes
Posted by "nbauma109 (via GitHub)" <gi...@apache.org>.
nbauma109 commented on code in PR #180:
URL: https://github.com/apache/commons-bcel/pull/180#discussion_r1161074933
##########
src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier.tests;
+
+/*
+ * A selection of JVM opcodes, each one in a minimal method.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #180: verifier tests on various opcodes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #180:
URL: https://github.com/apache/commons-bcel/pull/180#discussion_r1161025515
##########
src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.bcel.verifier.tests;
+
+/*
+ * A selection of JVM opcodes, each one in a minimal method.
Review Comment:
Each method should document which op code is tested, this will allow others to fill in any future op codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on pull request #180: verifier tests on various opcodes
Posted by "nbauma109 (via GitHub)" <gi...@apache.org>.
nbauma109 commented on PR #180:
URL: https://github.com/apache/commons-bcel/pull/180#issuecomment-1424307303
Hi @garydgregory
Anything wrong with this PR ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #180: verifier tests on various opcodes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #180:
URL: https://github.com/apache/commons-bcel/pull/180#issuecomment-1336448467
# [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/180?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#180](https://codecov.io/gh/apache/commons-bcel/pull/180?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b356007) into [master](https://codecov.io/gh/apache/commons-bcel/commit/e86f1f6a54b326060ab88f2b60000043342456f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e86f1f6) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #180 +/- ##
============================================
- Coverage 61.64% 61.42% -0.23%
+ Complexity 3654 3652 -2
============================================
Files 363 363
Lines 15633 15630 -3
Branches 1950 1943 -7
============================================
- Hits 9637 9600 -37
+ Misses 5122 5121 -1
- Partials 874 909 +35
```
| [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/bcel/util/ModularRuntimeImage.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdXRpbC9Nb2R1bGFyUnVudGltZUltYWdlLmphdmE=) | `7.14% <0.00%> (-78.58%)` | :arrow_down: |
| [.../main/java/org/apache/bcel/classfile/NestHost.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL05lc3RIb3N0LmphdmE=) | `0.00% <0.00%> (-54.17%)` | :arrow_down: |
| [...in/java/org/apache/bcel/classfile/NestMembers.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL05lc3RNZW1iZXJzLmphdmE=) | `0.00% <0.00%> (-48.72%)` | :arrow_down: |
| [.../bcel/verifier/exc/AssertionViolatedException.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvZXhjL0Fzc2VydGlvblZpb2xhdGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (-35.00%)` | :arrow_down: |
| [src/main/java/org/apache/bcel/util/ClassPath.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdXRpbC9DbGFzc1BhdGguamF2YQ==) | `42.40% <0.00%> (-11.79%)` | :arrow_down: |
| [...c/main/java/org/apache/bcel/classfile/Unknown.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL1Vua25vd24uamF2YQ==) | `42.85% <0.00%> (-5.72%)` | :arrow_down: |
| [...he/bcel/verifier/statics/StringRepresentation.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RhdGljcy9TdHJpbmdSZXByZXNlbnRhdGlvbi5qYXZh) | `34.54% <0.00%> (-5.46%)` | :arrow_down: |
| [.../org/apache/bcel/classfile/LocalVariableTable.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0xvY2FsVmFyaWFibGVUYWJsZS5qYXZh) | `63.04% <0.00%> (-4.35%)` | :arrow_down: |
| [...ache/bcel/verifier/structurals/Pass3bVerifier.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvdmVyaWZpZXIvc3RydWN0dXJhbHMvUGFzczNiVmVyaWZpZXIuamF2YQ==) | `64.02% <0.00%> (-3.60%)` | :arrow_down: |
| [...n/java/org/apache/bcel/classfile/EmptyVisitor.java](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0VtcHR5VmlzaXRvci5qYXZh) | `91.52% <0.00%> (-3.39%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/commons-bcel/pull/180/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org