[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3679: [WIP]: Update_delete_issue

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3679: [WIP]:  Update_delete_issue
URL: https://github.com/apache/carbondata/pull/3679#discussion_r398312583
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/DistributedPruneRDD.scala
 ##########
 @@ -143,6 +143,7 @@ private[indexserver] class DistributedPruneRDD(@transient private val ss: SparkS
         val reader = dataMapFormat.createRecordReader(inputSplit, attemptContextImpl)
         reader.initialize(inputSplit, attemptContextImpl)
         while (reader.nextKeyValue()) {
+          reader.getCurrentValue.setRowCount(reader.getCurrentValue.getDetailInfo.getRowCount)
 
 Review comment:
   getCurrentValue is called 3 times here now !
   
   better to call once and set value or handle it inside.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services