[GitHub] pivotal-jbarrett commented on a change in pull request #51: GEODE-6332: Add function execution benchmarks.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #51: GEODE-6332: Add function execution benchmarks.
URL: https://github.com/apache/geode-benchmarks/pull/51#discussion_r253632346
 
 

 ##########
 File path: geode-benchmarks/src/main/java/benchmark/geode/data/BenchmarkFunction.java
 ##########
 @@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package benchmark.geode.data;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.execute.Function;
+import org.apache.geode.cache.execute.FunctionContext;
+import org.apache.geode.cache.execute.RegionFunctionContext;
+
+public class BenchmarkFunction implements Function {
+  private long maxKey;
+  private long minKey;
+
+  public BenchmarkFunction(long minKey, long maxKey) {
+    this.maxKey = maxKey;
+    this.minKey = minKey;
+  }
+
+  @Override
+  public void execute(FunctionContext context) {
+    RegionFunctionContext regionFunctionContext = (RegionFunctionContext) context;
+    Region region = regionFunctionContext.getDataSet();
+    List<Long> results = new ArrayList<>();
+
+    for (long i = minKey; i <= maxKey; i++) {
 
 Review comment:
   I question what we really end up benchmarking here. The way I see it we re-bench get operations here more than anything.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services