You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/03/19 09:51:24 UTC
[PR] feat(catalog): capabilities properties [camel-k-runtime]
squakez opened a new pull request, #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185
<!-- Description -->
With this PR we enrich the catalog and let certain runtime aspects to be managed via properties (with something similar to this draft [1]). Together with a work on the operator, we'll be able to simplify the management of runtimes and offload the specific runtime aspects, being able to delegate this to the runtime directly. The result of this PR will enrich 3.8.0 future catalog as following:
```
health:
dependencies:
- groupId: org.apache.camel.quarkus
artifactId: camel-quarkus-microprofile-health
runtimeProperties:
- key: defaultLivenessProbePath
value: /q/health/live
- key: defaultReadinessProbePath
value: /q/health/ready
- key: defaultStartupProbePath
value: /q/health/started
...
logging:
runtimeProperties:
- key: color
value: quarkus.console.color
- key: format
value: quarkus.log.console.format
- key: json
value: quarkus.log.console.json
- key: jsonPrettyPrint
value: quarkus.log.console.json.pretty-print
- key: level
value: quarkus.log.level
...
master:
dependencies:
- groupId: org.apache.camel.k
artifactId: camel-k-master
runtimeProperties:
- key: labelKeyFormat
value: quarkus.camel.cluster.kubernetes.labels."%s"
- key: resourceName
value: quarkus.camel.cluster.kubernetes.resource-name
- key: resourceType
value: quarkus.camel.cluster.kubernetes.resource-type
buildTimeProperties:
- key: enabled
value: quarkus.camel.cluster.kubernetes.enabled
...
telemetry:
dependencies:
- groupId: org.apache.camel.quarkus
artifactId: camel-quarkus-opentelemetry
runtimeProperties:
- key: endpoint
value: quarkus.opentelemetry.tracer.exporter.otlp.endpoint
- key: sampler
value: quarkus.opentelemetry.tracer.sampler
- key: samplerParentBased
value: quarkus.opentelemetry.tracer.sampler.parent-based
- key: samplerRatio
value: quarkus.opentelemetry.tracer.sampler.ratio
- key: serviceName
value: quarkus.opentelemetry.tracer.resource-attributes
```
Eventually any other runtime (ie Springboot) should be adding the specific capabilities accordingly and it would be transparent for the operator.
[1] https://github.com/apache/camel-k/pull/5251
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(catalog): capabilities properties
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#issuecomment-2007061958
@lburgazzoli I've addressed the `metadata` properties. As mentioned for the other concern, although it's valid I think it is not relevant to this PR and will have to be solved regardless of this. Let me know if you have any objection to merge, so I can start the related work on the operator side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530093304
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
the main issue is about cognitive load as one has to take into account that for the health, they have a different meaning than for other traits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530092608
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -483,18 +488,32 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentracing"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "tracing", artifacts, false);
+ // Telemetry capability
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentelemetry"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "telemetry", artifacts, false);
-
- artifacts.clear();
- artifacts.add(Artifact.from("org.apache.camel.k", "camel-k-master"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "master", artifacts, true);
+ properties.clear();
+ properties.add(Property.from("endpoint", "quarkus.opentelemetry.tracer.exporter.otlp.endpoint"));
+ properties.add(Property.from("serviceName", "quarkus.opentelemetry.tracer.resource-attributes"));
+ properties.add(Property.from("sampler", "quarkus.opentelemetry.tracer.sampler"));
+ properties.add(Property.from("samplerRatio", "quarkus.opentelemetry.tracer.sampler.ratio"));
+ properties.add(Property.from("samplerParentBased", "quarkus.opentelemetry.tracer.sampler.parent-based"));
Review Comment:
Correct. I think this would be the next step when we onboard the new runtime. We'd need to understand how to harmonize the parameters expected by the operator according to the different runtimes requirements. The goal of this PR is to move towards that goal without breaking compatibility of what's expected now. Eventually it will be a matter of changing these parameters in the future catalog releases, driven by the changes in the operator as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530145201
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
No, I think it would be an additional configuration, not a replacement. The same `metadata` can be provided for other stuff that may be required with the meaning of "generic" configuration that have to be managed by the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#issuecomment-2007325072
Is it planned to backport to 3.2.x / 3.6.x for backward compatibility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530151099
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
I meant, if we leave them as `properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#issuecomment-2007326012
This idea in general is good as the description says, so +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530239825
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -483,18 +488,32 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentracing"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "tracing", artifacts, false);
+ // Telemetry capability
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentelemetry"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "telemetry", artifacts, false);
-
- artifacts.clear();
- artifacts.add(Artifact.from("org.apache.camel.k", "camel-k-master"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "master", artifacts, true);
+ properties.clear();
+ properties.add(Property.from("endpoint", "quarkus.opentelemetry.tracer.exporter.otlp.endpoint"));
+ properties.add(Property.from("serviceName", "quarkus.opentelemetry.tracer.resource-attributes"));
+ properties.add(Property.from("sampler", "quarkus.opentelemetry.tracer.sampler"));
+ properties.add(Property.from("samplerRatio", "quarkus.opentelemetry.tracer.sampler.ratio"));
+ properties.add(Property.from("samplerParentBased", "quarkus.opentelemetry.tracer.sampler.parent-based"));
Review Comment:
I acknowledge them but this PR doesn't aim to solve this aspect. This is something we need to address regardless this PR. Do you think that challenge can be tackled separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530246858
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
Ah, yes, I was agreeing with you. I do sometime :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530106530
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -483,18 +488,32 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentracing"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "tracing", artifacts, false);
+ // Telemetry capability
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentelemetry"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "telemetry", artifacts, false);
-
- artifacts.clear();
- artifacts.add(Artifact.from("org.apache.camel.k", "camel-k-master"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "master", artifacts, true);
+ properties.clear();
+ properties.add(Property.from("endpoint", "quarkus.opentelemetry.tracer.exporter.otlp.endpoint"));
+ properties.add(Property.from("serviceName", "quarkus.opentelemetry.tracer.resource-attributes"));
+ properties.add(Property.from("sampler", "quarkus.opentelemetry.tracer.sampler"));
+ properties.add(Property.from("samplerRatio", "quarkus.opentelemetry.tracer.sampler.ratio"));
+ properties.add(Property.from("samplerParentBased", "quarkus.opentelemetry.tracer.sampler.parent-based"));
Review Comment:
I guess there are many more questions that must be answered, i.e. :
- how to handle cases where a key is not applicable, but another one is needed
- how to handle breaking changes, so properties that have disappeared or become required ('d like to avoid having to do version checks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#issuecomment-2007343220
> Is it planned to backport to 3.2.x / 3.6.x for backward compatibility ?
No. The compatibility will be managed at runtime, ie, 3.2 runtime mechanism will work in its own way, according to its spec. The operator will still have to handle (and deprecated as illustrated in https://github.com/apache/camel-k/pull/5251/files#diff-22dc2842d3dc75fd50c5856a16c240e8c17dc3f9785d8ab14dc6eb6a990134beR70) also the older approach which will eventually disappear after deprecation policy has expired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530088271
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
True. We can use a generic metadata bucket of properties if you think it's worth. Let me rework this part, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530066641
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -483,18 +488,32 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentracing"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "tracing", artifacts, false);
+ // Telemetry capability
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-opentelemetry"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "telemetry", artifacts, false);
-
- artifacts.clear();
- artifacts.add(Artifact.from("org.apache.camel.k", "camel-k-master"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "master", artifacts, true);
+ properties.clear();
+ properties.add(Property.from("endpoint", "quarkus.opentelemetry.tracer.exporter.otlp.endpoint"));
+ properties.add(Property.from("serviceName", "quarkus.opentelemetry.tracer.resource-attributes"));
+ properties.add(Property.from("sampler", "quarkus.opentelemetry.tracer.sampler"));
+ properties.add(Property.from("samplerRatio", "quarkus.opentelemetry.tracer.sampler.ratio"));
+ properties.add(Property.from("samplerParentBased", "quarkus.opentelemetry.tracer.sampler.parent-based"));
Review Comment:
it would be nice to validate if i.e. the same keys also apply to spring-boot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530064526
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health", artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath", "/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath", "/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath", "/q/health/started"));
Review Comment:
nitpick: this does not seems a real property but more an endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530093408
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -526,6 +545,18 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-jaxb"));
artifacts.add(Artifact.from("org.jolokia", "jolokia-agent-jvm", "javaagent"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "jolokia", artifacts, true);
+
+ properties.clear();
+ properties.add(Property.from("level", "quarkus.log.level"));
+ properties.add(Property.from("color", "quarkus.console.color"));
+ properties.add(Property.from("format", "quarkus.log.console.format"));
+ properties.add(Property.from("json", "quarkus.log.console.json"));
+ properties.add(Property.from("jsonPrettyPrint", "quarkus.log.console.json.pretty-print"));
Review Comment:
Correct. Same comment as with the above telemetry capability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(catalog): capabilities properties [camel-k-runtime]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530073885
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -526,6 +545,18 @@ private void addCapabilities(RuntimeSpec.Builder runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus", "camel-quarkus-jaxb"));
artifacts.add(Artifact.from("org.jolokia", "jolokia-agent-jvm", "javaagent"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "jolokia", artifacts, true);
+
+ properties.clear();
+ properties.add(Property.from("level", "quarkus.log.level"));
+ properties.add(Property.from("color", "quarkus.console.color"));
+ properties.add(Property.from("format", "quarkus.log.console.format"));
+ properties.add(Property.from("json", "quarkus.log.console.json"));
+ properties.add(Property.from("jsonPrettyPrint", "quarkus.log.console.json.pretty-print"));
Review Comment:
I don't see a json logging option in spring-boot https://docs.spring.io/spring-boot/docs/3.0.0/reference/htmlsingle/#features.logging, it seems that to enable json logging one has to use a backend specific logging configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org