You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/05 23:06:32 UTC
Review Request 33863: change confirmation message for Delete widget
confirmation popup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33863/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-10942
https://issues.apache.org/jira/browse/AMBARI-10942
Repository: ambari
Description
-------
1. Show different messages for shared and unshared widgets
2. Read only user should not be shown the checkbox to filter unshared widgets in the footer of the widget browser
Diffs
-----
ambari-web/app/controllers/main/service/info/summary.js 58c0605
ambari-web/app/messages.js 5998098
ambari-web/app/templates/common/modal_popups/confirmation_feedback.hbs bda28b8
ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs PRE-CREATION
Diff: https://reviews.apache.org/r/33863/diff/
Testing
-------
tested the patch on a cluster.
All existing unit tests passess successfully with the patch
Thanks,
Jaimin Jetly
Re: Review Request 33863: change confirmation message for Delete
widget confirmation popup
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33863/#review82583
-----------------------------------------------------------
Ship it!
Ship It!
- Xi Wang
On May 5, 2015, 2:06 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33863/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 2:06 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-10942
> https://issues.apache.org/jira/browse/AMBARI-10942
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Show different messages for shared and unshared widgets
> 2. Read only user should not be shown the checkbox to filter unshared widgets in the footer of the widget browser
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/summary.js 58c0605
> ambari-web/app/messages.js 5998098
> ambari-web/app/templates/common/modal_popups/confirmation_feedback.hbs bda28b8
> ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33863/diff/
>
>
> Testing
> -------
>
> tested the patch on a cluster.
> All existing unit tests passess successfully with the patch
>
>
> Thanks,
>
> Jaimin Jetly
>
>