You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David Mollitor <da...@gmail.com> on 2019/12/09 19:38:30 UTC
HIVE-22066: Upgrade Apache parent POM to version 21
Hello Gang,
I have taken up the task of upgrading all of the Hive POM files to upgrade
the version of the Apache parent POM from which they inherent.
I have hit a snag though and I would like to ask your support.
The upgraded POM files builds locally for me but I cannot get it to pass
upstream. I tracked the problem back to how YETUS is implemented. YETUS's
first phase checks out and builds the 'master' branch of the project and
performs some sanity checks. It builds the root project and all of its
modules. For its second phase, it applies the submitted patch and builds
the project again. However, YETUS does not build from the root POM file on
the second phase. It only builds from directory of each module. This is
problematic since my patch updates the parent POM file. It looks to me
that YETUS will only build the parent POM file during phase 2 if the POM
file was modified to change the version number of the project. I am not
incrementing the version here, I am hoping to get this into Hive 4.0.
I would like to propose that we merge the latest patch I have provided and
work out any issues that may arise after the fact. Future builds should
succeed since YETUS will build the modified root POM file for future builds.
Thanks
Re: HIVE-22066: Upgrade Apache parent POM to version 21
Posted by David Mollitor <da...@gmail.com>.
Hello Gang,
I just pushed this change to the master. Please be kind and patient and
let's try to correct any artifacts that may pop up as a result.
Thanks.
On Fri, Jan 17, 2020 at 9:31 AM David Mollitor <da...@gmail.com> wrote:
> Hello Team,
>
> This ticket and patch is still waiting out there. Any help would be
> greatly appreciated.
>
> Thanks.
>
> On Mon, Dec 9, 2019 at 2:38 PM David Mollitor <da...@gmail.com> wrote:
>
>> Hello Gang,
>>
>> I have taken up the task of upgrading all of the Hive POM files to
>> upgrade the version of the Apache parent POM from which they inherent.
>>
>> I have hit a snag though and I would like to ask your support.
>>
>> The upgraded POM files builds locally for me but I cannot get it to pass
>> upstream. I tracked the problem back to how YETUS is implemented. YETUS's
>> first phase checks out and builds the 'master' branch of the project and
>> performs some sanity checks. It builds the root project and all of its
>> modules. For its second phase, it applies the submitted patch and builds
>> the project again. However, YETUS does not build from the root POM file on
>> the second phase. It only builds from directory of each module. This is
>> problematic since my patch updates the parent POM file. It looks to me
>> that YETUS will only build the parent POM file during phase 2 if the POM
>> file was modified to change the version number of the project. I am not
>> incrementing the version here, I am hoping to get this into Hive 4.0.
>>
>> I would like to propose that we merge the latest patch I have provided
>> and work out any issues that may arise after the fact. Future builds
>> should succeed since YETUS will build the modified root POM file for future
>> builds.
>>
>> Thanks
>>
>
Re: HIVE-22066: Upgrade Apache parent POM to version 21
Posted by David Mollitor <da...@gmail.com>.
Hello Team,
This ticket and patch is still waiting out there. Any help would be
greatly appreciated.
Thanks.
On Mon, Dec 9, 2019 at 2:38 PM David Mollitor <da...@gmail.com> wrote:
> Hello Gang,
>
> I have taken up the task of upgrading all of the Hive POM files to upgrade
> the version of the Apache parent POM from which they inherent.
>
> I have hit a snag though and I would like to ask your support.
>
> The upgraded POM files builds locally for me but I cannot get it to pass
> upstream. I tracked the problem back to how YETUS is implemented. YETUS's
> first phase checks out and builds the 'master' branch of the project and
> performs some sanity checks. It builds the root project and all of its
> modules. For its second phase, it applies the submitted patch and builds
> the project again. However, YETUS does not build from the root POM file on
> the second phase. It only builds from directory of each module. This is
> problematic since my patch updates the parent POM file. It looks to me
> that YETUS will only build the parent POM file during phase 2 if the POM
> file was modified to change the version number of the project. I am not
> incrementing the version here, I am hoping to get this into Hive 4.0.
>
> I would like to propose that we merge the latest patch I have provided and
> work out any issues that may arise after the fact. Future builds should
> succeed since YETUS will build the modified root POM file for future builds.
>
> Thanks
>