Please review change to JavaComponentBuilder, was: Re: svn commit: r528917

[Jean-Sebastien Delfino <js...@apache.org>]

Could you please review this change?

I was surprised to see that the handleResources() method was not called 
anymore by the builder, so the PojoComponentContextFactory was not added 
to the component and ComponentContexts were not getting injected 
properly into Java component implementation instances. I added the call 
to handleResources back and ComponentContexts are now injected properly. 
Also all tests are passing, but I'd like people to review this change, 
as there was probably a good reason to remove the call to 
handleResources() at one point.

Thanks

jsdelfino@apache.org wrote:
> Author: jsdelfino
> Date: Sat Apr 14 20:22:34 2007
> New Revision: 528917
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=528917
> Log:
> Added call to handleResources to configure injection of ComponentContext and RequestContext into Java implementations.
>
> Modified:
>     incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/implementation/java/context/JavaComponentBuilder.java
>
> Modified: incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/implementation/java/context/JavaComponentBuilder.java
> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/implementation/java/context/JavaComponentBuilder.java?view=diff&rev=528917&r1=528916&r2=528917
> ==============================================================================
> --- incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/implementation/java/context/JavaComponentBuilder.java (original)
> +++ incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/implementation/java/context/JavaComponentBuilder.java Sat Apr 14 20:22:34 2007
> @@ -66,6 +66,8 @@
>          if (componentType.getConversationIDMember() != null) {
>              component.addConversationIDFactory(componentType.getConversationIDMember());
>          }
> +        
> +        handleResources(componentType, component);
>  
>          return component;
>      }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>
>
>   


-- 
Jean-Sebastien


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org