You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2025/11/04 07:23:22 UTC
[PR] Update IT Dockerfile to Temurin. (druid)
gianm opened a new pull request, #18712:
URL: https://github.com/apache/druid/pull/18712
The previous image `openjdk:17-slim-bullseye` is deprecated, along with all openjdk images generally.
There have also been errors in recent PRs such as https://github.com/apache/druid/actions/runs/19058311667/job/54435078954?pr=18708, which suggest the deprecated image is not currently available. Good excuse to migrate off:
```
ERROR: failed to build: failed to solve: openjdk:17-slim-bullseye: failed to resolve source metadata for docker.io/library/openjdk:17-slim-bullseye: docker.io/library/openjdk:17-slim-bullseye: not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update IT Dockerfile to Temurin. (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #18712:
URL: https://github.com/apache/druid/pull/18712#discussion_r2502030678
##########
integration-tests/script/docker_build_containers.sh:
##########
@@ -34,7 +34,7 @@ else
11 | 17 | 21)
echo "Build druid-cluster with Java $DRUID_INTEGRATION_TEST_JVM_RUNTIME"
docker build -t druid/cluster \
- --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-slim-bullseye \
+ --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy \
Review Comment:
my bad... `-` does separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update IT Dockerfile to Temurin. (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #18712:
URL: https://github.com/apache/druid/pull/18712#discussion_r2502030678
##########
integration-tests/script/docker_build_containers.sh:
##########
@@ -34,7 +34,7 @@ else
11 | 17 | 21)
echo "Build druid-cluster with Java $DRUID_INTEGRATION_TEST_JVM_RUNTIME"
docker build -t druid/cluster \
- --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-slim-bullseye \
+ --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy \
Review Comment:
I think this should correctly be
```
--build-arg JDK_VERSION=${DRUID_INTEGRATION_TEST_JVM_RUNTIME}-jre-jammy \
```
the current value of that variable (`DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy`) will be unset all the time.
this implicitly means that this build arg was unset all the time and alternate jdk version checks were running the same jdk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update IT Dockerfile to Temurin. (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #18712:
URL: https://github.com/apache/druid/pull/18712#discussion_r2502030678
##########
integration-tests/script/docker_build_containers.sh:
##########
@@ -34,7 +34,7 @@ else
11 | 17 | 21)
echo "Build druid-cluster with Java $DRUID_INTEGRATION_TEST_JVM_RUNTIME"
docker build -t druid/cluster \
- --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-slim-bullseye \
+ --build-arg JDK_VERSION=$DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy \
Review Comment:
I think this should correctly be
```
--build-arg JDK_VERSION=${DRUID_INTEGRATION_TEST_JVM_RUNTIME}-jre-jammy \
```
the current value of that variable (`DRUID_INTEGRATION_TEST_JVM_RUNTIME-jre-jammy`) will be unset all the time.
this implicitly means that this build arg was unset all the time and alternate jdk version checks were running the same jdk
my bad... `-` does separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update IT Dockerfile to Temurin. (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 merged PR #18712:
URL: https://github.com/apache/druid/pull/18712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org