You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Eran Chinthaka (JIRA)" <ji...@apache.org> on 2006/06/01 13:42:30 UTC
[jira] Commented: (WSCOMMONS-38) SOAP11FaultCodeImpl contains SOAP
1.2 local name
[ http://issues.apache.org/jira/browse/WSCOMMONS-38?page=comments#action_12414221 ]
Eran Chinthaka commented on WSCOMMONS-38:
-----------------------------------------
I'd prefer if you could raise this issue in the mailing list so that answering for each and every point would have been easier.
About SOAP classes packaging :
Let me explain the rationale behind the current Fault implementation. It was by design we made SOAP 1.2 as the visible api. As you all know there are some differences between SOAP 1.1 and SOAP 1.2. We selected the second option.
What that means is our prime api is SOAP 1.2 ish. So its correct to have them in o.a.a.soap.impl.llom.
About SOAP fault name not being overriden :
If both the names are the same I didn't see any reason behind overriding it un-necessarily. Perhaps we might change the name a bit.
> SOAP11FaultCodeImpl contains SOAP 1.2 local name
> ------------------------------------------------
>
> Key: WSCOMMONS-38
> URL: http://issues.apache.org/jira/browse/WSCOMMONS-38
> Project: WS-Commons
> Type: Bug
> Components: AXIOM
> Environment: AXIOM 1.0, JDK 1.5
> Reporter: Arjen Poutsma
> Assignee: Eran Chinthaka
>
> The class org.apache.axiom.soap.impl.llom.soap11.SOAP11FaultCodeImpl does not override the localname of its parent org.apache.axiom.soap.impl.llom.SOAPFaultCodeImpl. Since this parent class contains the SOAP 1.2 specific SOAP12Constants.SOAP_FAULT_CODE_LOCAL_NAME as localname, the localname is of the SOAP 1.1 subclass is not set correctly.
> Oviously, this code should be in org.apache.axiom.soap.impl.llom.soap12.SOAP12FaultCodeImpl, and not in the non-version specific superclass. In general, there seems to be a lot of defaulting to SOAP 1.2-specific stuff in the org.apache.axiom.soap.impl.llom package. This should be moved to the version-specific subclasses.
> The errors become clear when obtaining an XMLStreamReader from the fault code, and reading from that. Serializing to an outputstream does work correctly, since the serialize methods are properly overridden.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org