You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@maven.org> on 2006/12/30 03:16:15 UTC

Re: svn commit: r491098 - /maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml

On 29 Dec 06, at 4:11 PM 29 Dec 06, brett@apache.org wrote:

> Author: brett
> Date: Fri Dec 29 13:11:36 2006
> New Revision: 491098
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=491098
> Log:
> add the release profile for this release. In the future, this will  
> be in a parent POM and can be removed from here
>

I think I'm going to whip something up akin to the remote resources  
where a profile can also be deployed and shared globally if desired.  
Nothing should be buried inside the Super POM.

Jason.

> Modified:
>     maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
>
> Modified: maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
> URL: http://svn.apache.org/viewvc/maven/shared/branches/maven- 
> plugin-tools-2.0.x/pom.xml?view=diff&rev=491098&r1=491097&r2=491098
> ====================================================================== 
> ========
> --- maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml (original)
> +++ maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml Fri Dec  
> 29 13:11:36 2006
> @@ -24,7 +24,7 @@
>    <parent>
>      <groupId>org.apache.maven.shared</groupId>
>      <artifactId>maven-shared-components</artifactId>
> -    <version>4-SNAPSHOT</version>
> +    <version>6</version>
>    </parent>
>    <modelVersion>4.0.0</modelVersion>
>    <groupId>org.apache.maven</groupId>
> @@ -73,4 +73,50 @@
>        </dependency>
>      </dependencies>
>    </dependencyManagement>
> +  <profiles>
> +    <profile>
> +      <id>release-profile</id>
> +      <activation>
> +        <property>
> +          <name>performRelease</name>
> +          <value>true</value>
> +        </property>
> +      </activation>
> +      <build>
> +        <plugins>
> +          <plugin>
> +            <artifactId>maven-gpg-plugin</artifactId>
> +            <version>1.0-alpha-1</version>
> +            <configuration>
> +              <passphrase>${gpg.passphrase}</passphrase>
> +            </configuration>
> +            <executions>
> +              <execution>
> +                <goals>
> +                  <goal>sign</goal>
> +                </goals>
> +              </execution>
> +            </executions>
> +          </plugin>
> +          <!-- We want to package up license resources in the JARs  
> produced -->
> +          <plugin>
> +            <artifactId>maven-remote-resources-plugin</artifactId>
> +            <version>1.0-alpha-1</version>
> +            <executions>
> +              <execution>
> +                <goals>
> +                  <goal>process</goal>
> +                </goals>
> +                <configuration>
> +                  <resourceBundles>
> +                    <resourceBundle>org.apache:apache-jar-resource- 
> bundle:1.0</resourceBundle>
> +                  </resourceBundles>
> +                </configuration>
> +              </execution>
> +            </executions>
> +          </plugin>
> +        </plugins>
> +      </build>
> +    </profile>
> +  </profiles>
>  </project>
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r491098 - /maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml

Posted by Brett Porter <br...@apache.org>.
Ok - I guess I'm interested in the actual mechanics. I was initially  
thinking you were customising Maven's profile handling itself, but  
I'm seeing now you are talking about the release plugin. so it is  
actually not using the profile at all any more, and instead grabbing  
sum plugin descriptions from the repository and applying that?  
Perhaps by writing out a profiles.xml in the directory of the project  
that is being released?

That I like - in fact, that was something I was broadly hoping to  
look at as a fully-fledged feature in 2.1, but it can certainly start  
in the release plugin.

The only stumbling point will be backwards compatibility - you'll  
still need to send -DperformRelease=true from release:perform so that  
anyone that has set up actions to trigger from that still can, and  
that will mean for those using maven-2.0.x you'll still be receiving  
the old plugin definitions from the super POM so you won't be able to  
rely on a clean slate.

- Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r491098 - /maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml

Posted by Jason van Zyl <ja...@maven.org>.
On 29 Dec 06, at 9:39 PM 29 Dec 06, Brett Porter wrote:

> I wasn't suggesting the super super POM - I was suggesting the  
> maven/ASF POM where I think it makes sense?
>
> I'm not sure about sharing a profile in this way, doesn't sound  
> like the right solution to me.
>

For the simple type of releases we do the two variants that would  
apply to 99% of projects. Direct releases, and staged releases.  
Beyond that we're getting into workflow. As such I think pulling them  
from the repository would be ideal. Best place to share resources from.

> I think the preferred solution might be for the release plugin to  
> be able to introduce a profile and overlay it onto a project,  
> rather than having it specified in the super POM. WDYT?
>

Yes, but where is the profile going to come from? I just want to  
fetch that profiles from the repository where the two most commonly  
used variants are available to everyone.

Jason.

> - Brett
>
> On 30/12/2006, at 1:16 PM, Jason van Zyl wrote:
>
>> On 29 Dec 06, at 4:11 PM 29 Dec 06, brett@apache.org wrote:
>>
>>> Author: brett
>>> Date: Fri Dec 29 13:11:36 2006
>>> New Revision: 491098
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=491098
>>> Log:
>>> add the release profile for this release. In the future, this  
>>> will be in a parent POM and can be removed from here
>>>
>>
>> I think I'm going to whip something up akin to the remote  
>> resources where a profile can also be deployed and shared globally  
>> if desired. Nothing should be buried inside the Super POM.
>>
>> Jason.
>>
>>> Modified:
>>>     maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
>>>
>>> Modified: maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
>>> URL: http://svn.apache.org/viewvc/maven/shared/branches/maven- 
>>> plugin-tools-2.0.x/pom.xml?view=diff&rev=491098&r1=491097&r2=491098
>>> ==================================================================== 
>>> ==========
>>> --- maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml  
>>> (original)
>>> +++ maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml Fri  
>>> Dec 29 13:11:36 2006
>>> @@ -24,7 +24,7 @@
>>>    <parent>
>>>      <groupId>org.apache.maven.shared</groupId>
>>>      <artifactId>maven-shared-components</artifactId>
>>> -    <version>4-SNAPSHOT</version>
>>> +    <version>6</version>
>>>    </parent>
>>>    <modelVersion>4.0.0</modelVersion>
>>>    <groupId>org.apache.maven</groupId>
>>> @@ -73,4 +73,50 @@
>>>        </dependency>
>>>      </dependencies>
>>>    </dependencyManagement>
>>> +  <profiles>
>>> +    <profile>
>>> +      <id>release-profile</id>
>>> +      <activation>
>>> +        <property>
>>> +          <name>performRelease</name>
>>> +          <value>true</value>
>>> +        </property>
>>> +      </activation>
>>> +      <build>
>>> +        <plugins>
>>> +          <plugin>
>>> +            <artifactId>maven-gpg-plugin</artifactId>
>>> +            <version>1.0-alpha-1</version>
>>> +            <configuration>
>>> +              <passphrase>${gpg.passphrase}</passphrase>
>>> +            </configuration>
>>> +            <executions>
>>> +              <execution>
>>> +                <goals>
>>> +                  <goal>sign</goal>
>>> +                </goals>
>>> +              </execution>
>>> +            </executions>
>>> +          </plugin>
>>> +          <!-- We want to package up license resources in the  
>>> JARs produced -->
>>> +          <plugin>
>>> +            <artifactId>maven-remote-resources-plugin</artifactId>
>>> +            <version>1.0-alpha-1</version>
>>> +            <executions>
>>> +              <execution>
>>> +                <goals>
>>> +                  <goal>process</goal>
>>> +                </goals>
>>> +                <configuration>
>>> +                  <resourceBundles>
>>> +                    <resourceBundle>org.apache:apache-jar- 
>>> resource-bundle:1.0</resourceBundle>
>>> +                  </resourceBundles>
>>> +                </configuration>
>>> +              </execution>
>>> +            </executions>
>>> +          </plugin>
>>> +        </plugins>
>>> +      </build>
>>> +    </profile>
>>> +  </profiles>
>>>  </project>
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r491098 - /maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml

Posted by Brett Porter <br...@apache.org>.
I wasn't suggesting the super super POM - I was suggesting the maven/ 
ASF POM where I think it makes sense?

I'm not sure about sharing a profile in this way, doesn't sound like  
the right solution to me.

I think the preferred solution might be for the release plugin to be  
able to introduce a profile and overlay it onto a project, rather  
than having it specified in the super POM. WDYT?

- Brett

On 30/12/2006, at 1:16 PM, Jason van Zyl wrote:

> On 29 Dec 06, at 4:11 PM 29 Dec 06, brett@apache.org wrote:
>
>> Author: brett
>> Date: Fri Dec 29 13:11:36 2006
>> New Revision: 491098
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=491098
>> Log:
>> add the release profile for this release. In the future, this will  
>> be in a parent POM and can be removed from here
>>
>
> I think I'm going to whip something up akin to the remote resources  
> where a profile can also be deployed and shared globally if  
> desired. Nothing should be buried inside the Super POM.
>
> Jason.
>
>> Modified:
>>     maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
>>
>> Modified: maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml
>> URL: http://svn.apache.org/viewvc/maven/shared/branches/maven- 
>> plugin-tools-2.0.x/pom.xml?view=diff&rev=491098&r1=491097&r2=491098
>> ===================================================================== 
>> =========
>> --- maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml (original)
>> +++ maven/shared/branches/maven-plugin-tools-2.0.x/pom.xml Fri Dec  
>> 29 13:11:36 2006
>> @@ -24,7 +24,7 @@
>>    <parent>
>>      <groupId>org.apache.maven.shared</groupId>
>>      <artifactId>maven-shared-components</artifactId>
>> -    <version>4-SNAPSHOT</version>
>> +    <version>6</version>
>>    </parent>
>>    <modelVersion>4.0.0</modelVersion>
>>    <groupId>org.apache.maven</groupId>
>> @@ -73,4 +73,50 @@
>>        </dependency>
>>      </dependencies>
>>    </dependencyManagement>
>> +  <profiles>
>> +    <profile>
>> +      <id>release-profile</id>
>> +      <activation>
>> +        <property>
>> +          <name>performRelease</name>
>> +          <value>true</value>
>> +        </property>
>> +      </activation>
>> +      <build>
>> +        <plugins>
>> +          <plugin>
>> +            <artifactId>maven-gpg-plugin</artifactId>
>> +            <version>1.0-alpha-1</version>
>> +            <configuration>
>> +              <passphrase>${gpg.passphrase}</passphrase>
>> +            </configuration>
>> +            <executions>
>> +              <execution>
>> +                <goals>
>> +                  <goal>sign</goal>
>> +                </goals>
>> +              </execution>
>> +            </executions>
>> +          </plugin>
>> +          <!-- We want to package up license resources in the  
>> JARs produced -->
>> +          <plugin>
>> +            <artifactId>maven-remote-resources-plugin</artifactId>
>> +            <version>1.0-alpha-1</version>
>> +            <executions>
>> +              <execution>
>> +                <goals>
>> +                  <goal>process</goal>
>> +                </goals>
>> +                <configuration>
>> +                  <resourceBundles>
>> +                    <resourceBundle>org.apache:apache-jar- 
>> resource-bundle:1.0</resourceBundle>
>> +                  </resourceBundles>
>> +                </configuration>
>> +              </execution>
>> +            </executions>
>> +          </plugin>
>> +        </plugins>
>> +      </build>
>> +    </profile>
>> +  </profiles>
>>  </project>
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org