You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Steve Moist via Review Board <no...@reviews.apache.org> on 2017/11/15 21:47:59 UTC

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63775/
-----------------------------------------------------------

(Updated Nov. 15, 2017, 9:47 p.m.)


Review request for sentry.


Summary (updated)
-----------------

SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code


Bugs: SENTRY-1543
    https://issues.apache.org/jira/browse/SENTRY-1543


Repository: sentry


Description
-------

Renamed methods to be more clear in their use since they both have the same name but function and query differently.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7217dea7 


Diff: https://reviews.apache.org/r/63775/diff/1/


Testing
-------

Unit tests ran.


Thanks,

Steve Moist