You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by pa...@gmail.com on 2011/10/04 01:57:08 UTC
Review Request: OOZIE-567: Is sub-workflow lib directory being used?
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
OOZIE-567: Is sub-workflow lib directory not used?
Summary:
https://issues.apache.org/jira/browse/OOZIE-567
This addresses bug OOZIE-567.
https://issues.apache.org/jira/browse/OOZIE-567
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
trunk/release-log.txt 1178596
Diff: https://reviews.apache.org/r/2156/diff
Testing
-------
Tested against current test cases. Added two new test cases.
Thanks,
params
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2301
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
<https://reviews.apache.org/r/2156/#comment5301>
use the syntax like
if () {
}
- Mohammad
On 2011-10-03 23:57:08, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-03 23:57:08)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
> trunk/release-log.txt 1178596
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by "Angelo K. Huang" <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2377
-----------------------------------------------------------
Ship it!
+1
- Angelo K.
On 2011-10-04 03:40:26, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-04 03:40:26)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
> trunk/release-log.txt 1178596
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2404
-----------------------------------------------------------
committed
- Mohammad
On 2011-10-04 03:40:26, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-04 03:40:26)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
> trunk/release-log.txt 1178596
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2334
-----------------------------------------------------------
Ship it!
Pushing
- Mohammad
On 2011-10-04 03:40:26, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-04 03:40:26)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
> trunk/release-log.txt 1178596
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2523
-----------------------------------------------------------
=1 pushing.
- Mohammad
On 2011-10-12 02:02:44, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-12 02:02:44)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1182157
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/#review2527
-----------------------------------------------------------
committed. please close.
- Mohammad
On 2011-10-12 02:02:44, params wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2156/
> -----------------------------------------------------------
>
> (Updated 2011-10-12 02:02:44)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-567: Is sub-workflow lib directory not used?
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> This addresses bug OOZIE-567.
> https://issues.apache.org/jira/browse/OOZIE-567
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1182157
>
> Diff: https://reviews.apache.org/r/2156/diff
>
>
> Testing
> -------
>
> Tested against current test cases. Added two new test cases.
>
>
> Thanks,
>
> params
>
>
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by pa...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/
-----------------------------------------------------------
(Updated 2011-10-12 02:02:44.996150)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Fixed tests to assert on collections (rather than individual elements), so that accidental re-ordering of elements while running the tests doesn't fail them. This was observed on a random basis on some machines.
Summary
-------
OOZIE-567: Is sub-workflow lib directory not used?
Summary:
https://issues.apache.org/jira/browse/OOZIE-567
This addresses bug OOZIE-567.
https://issues.apache.org/jira/browse/OOZIE-567
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1182157
Diff: https://reviews.apache.org/r/2156/diff
Testing
-------
Tested against current test cases. Added two new test cases.
Thanks,
params
Re: Review Request: OOZIE-567: Is sub-workflow lib directory being used?
Posted by pa...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2156/
-----------------------------------------------------------
(Updated 2011-10-04 03:40:26.912026)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Incorporated review feedback from diff version1.
Summary
-------
OOZIE-567: Is sub-workflow lib directory not used?
Summary:
https://issues.apache.org/jira/browse/OOZIE-567
This addresses bug OOZIE-567.
https://issues.apache.org/jira/browse/OOZIE-567
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1178596
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1178596
trunk/release-log.txt 1178596
Diff: https://reviews.apache.org/r/2156/diff
Testing
-------
Tested against current test cases. Added two new test cases.
Thanks,
params