Re: [PR] [incubator-kie-issues-1924] removing reactive code from job service [incubator-kie-kogito-apps]

["elguardian (via GitHub)" <gi...@apache.org>]

elguardian commented on PR #2214:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2214#issuecomment-2846480058

   @ricardozanini As I did mention you can have reactive code at restendpoint level meaning that you will have worker threads instead of I/O threads. so that can be fixed that way. In any cases there is no such important implications in performance as timers are basically CRUD operations and timeouts are not based on reactive code so there is no much benefit in it either.
   
   I know pretty well the workflow engine and one single instance cannot handle all the request (it did no happen in the past in v8 with far more mature timer engine and it won't happen with this implementation), it is just not possible (not in compact architecutre and not even in distributed where  you have more problems like eventually consistency and phatom events). Currently this implementation won't be able to scale in the way it is required by the engine.
   
   As I did mention before you will still have reactive code at a higher level. (in any case we are chaining sequential calls with not parallelizable computational unit so at lower level there is no benefit of reactive code anyway.
   
   briefing a bit.
   
   1. Reactive code at rest endpoint level so you have separate threads in I/O and worker threads.
   2. CRUD operations at java interface level without it.
   3. Timeouts (vetx ones) requires to be executed in worker threads.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org