You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/07/24 21:48:47 UTC
Review Request 61089: Logged each container state transition.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Currently when container launch is blocked silently, it's hard to tell
which state it is in. Logging state transition helps with triaging.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
Diff: https://reviews.apache.org/r/61089/diff/1/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request 61089: Logged each container state transition.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/#review181281
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61089]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 24, 2017, 9:48 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61089/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 9:48 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently when container launch is blocked silently, it's hard to tell
> which state it is in. Logging state transition helps with triaging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/61089/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 61089: Logged each container state transition.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On July 26, 2017, 10:48 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 2599-2603 (patched)
> > <https://reviews.apache.org/r/61089/diff/1/?file=1781597#file1781597line2599>
> >
> > Would suggest we either
> > 1. add a check here: `CHECK(containers_.contains(containerId)`
> >
> > or
> >
> > 2. pass an `const Owned<Container>` pointer to transition() instead of the `ContainerID`.
> >
> > Thoughts?
I would prefer the former. Thanks for the suggestion.
The problem with the latter is that
- I'd like to log the `containerId` which is not in the `Container` but if I pass both, the API looks kind of stupid. Adding `containerId` to `Container` would probably overkill.
- Passing `Owned` to a method when you don't mean to pass on the ownership feels odd. Our pratices on `Owned` has always been murky but when possible I am sticking with the strict semantics.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/#review181472
-----------------------------------------------------------
On July 24, 2017, 2:48 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61089/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 2:48 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently when container launch is blocked silently, it's hard to tell
> which state it is in. Logging state transition helps with triaging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/61089/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 61089: Logged each container state transition.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/#review181472
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 2599-2603 (patched)
<https://reviews.apache.org/r/61089/#comment257081>
Would suggest we either
1. add a check here: `CHECK(containers_.contains(containerId)`
or
2. pass an `const Owned<Container>` pointer to transition() instead of the `ContainerID`.
Thoughts?
- Gilbert Song
On July 24, 2017, 2:48 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61089/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 2:48 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently when container launch is blocked silently, it's hard to tell
> which state it is in. Logging state transition helps with triaging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/61089/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 61089: Logged each container state transition.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/#review181648
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 26, 2017, 12:18 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61089/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 12:18 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently when container launch is blocked silently, it's hard to tell
> which state it is in. Logging state transition helps with triaging.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
>
>
> Diff: https://reviews.apache.org/r/61089/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 61089: Logged each container state transition.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61089/
-----------------------------------------------------------
(Updated July 26, 2017, 12:18 p.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Review comments.
Repository: mesos
Description
-------
Currently when container launch is blocked silently, it's hard to tell
which state it is in. Logging state transition helps with triaging.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp ea0691945d3450fcc336df03d9cf7b48afbd8b3d
src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
Diff: https://reviews.apache.org/r/61089/diff/2/
Changes: https://reviews.apache.org/r/61089/diff/1-2/
Testing
-------
make check
Thanks,
Jiang Yan Xu