You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/03/21 20:31:46 UTC

svn commit: r1303521 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Author: markt
Date: Wed Mar 21 19:31:45 2012
New Revision: 1303521

URL: http://svn.apache.org/viewvc?rev=1303521&view=rev
Log:
Some CI test failures show a cluster with 20 members when there should be 10. It looks like duplicates but those should be caught. Add some additional logging to try and figure out what is going on. 

Modified:
    tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java?rev=1303521&r1=1303520&r2=1303521&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java (original)
+++ tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java Wed Mar 21 19:31:45 2012
@@ -138,9 +138,21 @@ public class TestGroupChannelMemberArriv
 
         private void report(String event, Member member, int count) {
             StringBuilder message = new StringBuilder(100);
-            message.append(System.currentTimeMillis()).append(' ').append(name)
-                    .append(':').append(event).append(", has ").append(count)
-                    .append(" members now. Member:[");
+            message.append(System.currentTimeMillis());
+            message.append(' ');
+            message.append(name);
+            message.append(':');
+            message.append(event);
+            message.append(", has ");
+            message.append(count);
+            message.append(" members now. Member:[");
+            message.append("host: ");
+            appendByteArrayToString(message, member.getHost());
+            message.append(", port: ");
+            message.append(member.getPort());
+            message.append(", id: ");
+            appendByteArrayToString(message, member.getUniqueId());
+            message.append(", payload: ");
             try {
                 message.append(new String(member.getPayload(), "ASCII"));
             } catch (Exception x) {
@@ -151,6 +163,19 @@ public class TestGroupChannelMemberArriv
                     .append(t.hashCode());
             System.out.println(message);
         }
+
+        private void appendByteArrayToString(StringBuilder sb, byte[] input) {
+            if (input == null) {
+                sb.append("null");
+                return;
+            }
+            for (int i = 0; i < input.length; i++) {
+                if (i > 0) {
+                    sb.append('.');
+                }
+                sb.append(input[i] & 0xFF);
+            }
+        }
     }
 
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org