You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "prabhu7380 (via GitHub)" <gi...@apache.org> on 2026/10/14 17:20:07 UTC
[PR] [SPARK-34525][DOCS] Document that '=' is optional in DDL property lists [spark]
prabhu7380 opened a new pull request, #59471:
URL: https://github.com/apache/spark/pull/59471
The '=' delimiter between a key and its value in OPTIONS, TBLPROPERTIES, SERDEPROPERTIES and DBPROPERTIES is optional (space-delimited form is also accepted, see propertyWithKeyNoEquals in SqlBaseParser.g4). Update the DDL syntax docs to show '[=]' and note both forms are supported.
### What changes were proposed in this pull request?
Document that the `=` delimiter between a key and its value in `OPTIONS`, `TBLPROPERTIES`, `SERDEPROPERTIES` and `DBPROPERTIES` is optional — the space-delimited form is also accepted (see `propertyWithKeyNoEquals` in `SqlBaseParser.g4`). Updated the syntax blocks in 8 DDL doc pages (create/alter database, table datasource, hiveformat, like, view) to show `key [=] val` and noted in each parameter description that both forms work, e.g. `TBLPROPERTIES ('key1' 'val1')` is equivalent to `TBLPROPERTIES ('key1'='val1')`.
### Why are the changes needed?
Closes SPARK-34525. The docs only showed the `key=value` form, which misleads users into thinking `=` is required.
### Does this PR introduce _any_ user-facing change?
No. Documentation-only update; no behavior change.
### How was this patch tested?
Verified the `propertyWithKeyNoEquals` grammar rule in `sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4`. Documentation-only change; the full docs build was not run locally.
### Was this patch authored or co-authored using generative AI tooling?
No
This contribution is my original work and I license the work to the project under the project's open source license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-34525][DOCS] Document that '=' is optional in DDL property lists [spark]
Posted by "prabhu7380 (via GitHub)" <gi...@apache.org>.
prabhu7380 commented on PR #59471:
URL: https://github.com/apache/spark/pull/59471#issuecomment-6273005559
Hi, gentle ping on this docs fix for SPARK-34525. It documents that = is optional in DDL property lists (verified against propertyWithKeyNoEquals in SqlBaseParser.g4), using the [=] notation suggested on the earlier attempt #31899. Happy to adjust anything — thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org