[GitHub] [spark] HeartSaVioR commented on a change in pull request #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files
URL: https://github.com/apache/spark/pull/25488#discussion_r315003798
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLogSuite.scala
 ##########
 @@ -75,12 +91,16 @@ class HDFSMetadataLogSuite extends SparkFunSuite with SharedSQLContext {
       assert(metadataLog.get(2).isDefined)
       assert(metadataLog.getLatest().get._1 == 2)
 
-      // There should be exactly one file, called "2", in the metadata directory.
+      // There should be at most two files, called "2", and optionally crc file,
+      // in the metadata directory.
       // This check also tests for regressions of SPARK-17475
-      val allFiles = new File(metadataLog.metadataPath.toString).listFiles()
-        .filter(!_.getName.startsWith(".")).toSeq
 
 Review comment:
   This broke the check of regression on SPARK-17475, hence regression came in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org