You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2016/07/25 08:12:35 UTC

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Remove PushProjectThroughSampl...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14327#discussion_r72023822
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -422,6 +422,31 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
           3, 17, 27, 58, 62)
       }
     
    +  test("SPARK-16686: Dataset.sample with seed results shouldn't depend on downstream usage") {
    +    val udfOne = udf((n: Int) => {
    +      require(n != 1, "udfOne shouldn't see swid=1!")
    +      1
    +    })
    +
    +    val df = Seq(
    +      (0, "string0"),
    +      (1, "string1"),
    +      (2, "string2"),
    +      (3, "string3"),
    +      (4, "string4"),
    +      (5, "string5"),
    +      (6, "string6"),
    +      (7, "string7"),
    +      (8, "string8"),
    +      (9, "string9")
    +    ).toDF("swid", "stringData")
    --- End diff --
    
    what does `swid` mean?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org