You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Francis Liu (JIRA)" <ji...@apache.org> on 2012/10/30 00:38:13 UTC
[jira] [Created] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Francis Liu created HBASE-7066:
----------------------------------
Summary: Some HMaster coprocessor exceptions are being swallowed in try catch blocks
Key: HBASE-7066
URL: https://issues.apache.org/jira/browse/HBASE-7066
Project: HBase
Issue Type: Bug
Components: Coprocessors
Reporter: Francis Liu
Fix For: 0.96.0, 0.94.4
This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-7066) Some HMaster coprocessor
exceptions are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489825#comment-13489825 ]
Andrew Purtell edited comment on HBASE-7066 at 11/2/12 11:09 PM:
-----------------------------------------------------------------
bq. Passing information out of methods via exceptions is always a bit weird.
Maybe in the general case but throwing an access denied exception if a security policy fails check seems natural, common, and unsurprising to me.
bq. Can we instead make the coprocessor protocol be more explicit?
One early thought was an Enum instead of a Boolean. We went with "simpler is better". Changing this internal framework detail if we need it now seems reasonable to me.
was (Author: apurtell):
bq. Passing information out of methods via exceptions is always a bit weird.
Maybe in the general case but throwing an access denied exception if a security policy check seems natural, common, and unsurprising to me.
bq. Can we instead make the coprocessor protocol be more explicit?
One early thought was an Enum instead of a Boolean. We went with "simpler is better". Changing this internal framework detail if we need it now seems reasonable to me.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490130#comment-13490130 ]
Ted Yu commented on HBASE-7066:
-------------------------------
For 0.94, I think one benefit of throwing exception is that method signature for preShutdown() doesn't change.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489825#comment-13489825 ]
Andrew Purtell commented on HBASE-7066:
---------------------------------------
bq. Passing information out of methods via exceptions is always a bit weird.
Maybe in the general case but throwing an access denied exception if a security policy check seems natural, common, and unsurprising to me.
bq. Can we instead make the coprocessor protocol be more explicit?
One early thought was an Enum instead of a Boolean. We went with "simpler is better". Changing this internal framework detail if we need it now seems reasonable to me.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489788#comment-13489788 ]
Francis Liu commented on HBASE-7066:
------------------------------------
That sounds fine to me, though what do we do with the shutdown() method signature? Since we can't do "throws <Interface>"?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488822#comment-13488822 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Lars, if you agree that this fix is the right way to go. Can we get this into 0.94.3?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489554#comment-13489554 ]
stack commented on HBASE-7066:
------------------------------
[~toffer] Should the signature here, + public void shutdown() throws IOException {, instead be + public void shutdown() throws AccessDeniedException { ? When it is IOE, the implication is that we can IOE mid-shutdown which is not what we want. On other hand, if someone tries to shutdown the daemon when doesn't have permission, that is legit. Thanks F.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489946#comment-13489946 ]
Hadoop QA commented on HBASE-7066:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551969/7066-addendum.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 86 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3219//console
This message is automatically generated.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7066:
----------------------------------
Component/s: security
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489868#comment-13489868 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Scratch that, the return class would come from the coprocessor framework so it is core.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7066:
--------------------------
Attachment: 7066-addendum-v2.txt
Addendum v2 adds try / catch block for cpHost.preStopMaster().
stopMaster() and shutdown() modified by this JIRA are not in master interface. So the change is compatible.
Once review passs, I can provide patch for 0.94
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488198#comment-13488198 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Stack, IMHO it really depends on what the coprocessor wants. In the context of security, it'd be safer to err on the side of caution if the security module is unable to authorize a request, as this behavior may be exploited by a malicious user.
In general though we probably need a means for the coprocessor to communicate what can and can't be ignored.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489625#comment-13489625 ]
Ted Yu commented on HBASE-7066:
-------------------------------
I understand Stack's concern.
In 0.94, secure and insecure HBase have two separate builds. Would declaration of throwing AccessDeniedException be of any concern for insecure build ?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488818#comment-13488818 ]
Francis Liu commented on HBASE-7066:
------------------------------------
More specifically if AccessController.preShutdown() throws an IOException, shutdown should fail since we cannot truly determine whether the shutdown request is authorized and thus should err on the side of caution and fail the request.
There may be instances that preShutdown() hook exceptions can be ignored but that is not the case for AccessController which comes packaged with HBase thus it would make sense to guarantee that it works as advertised. We can address the previous scenario by fixing the coprocessor framework.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489708#comment-13489708 ]
Francis Liu commented on HBASE-7066:
------------------------------------
So just to summarize what to do with this issue:
- Change stopMaster() and shutdown() signature with "throws AccessDeniedException" and have the try-catch block rethrow AccessDeniedException (since it extends IOE)
- AccessController should wrap any exception that it doesn't want ignored with an AccessDeniedException
Thoughts?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7066:
----------------------------------
Priority: Critical (was: Major)
Affects Version/s: 0.96.0
0.94.2
Fix Version/s: (was: 0.94.4)
(was: 0.96.0)
+1
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489737#comment-13489737 ]
stack commented on HBASE-7066:
------------------------------
Sounds right to me
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489867#comment-13489867 ]
Francis Liu commented on HBASE-7066:
------------------------------------
return vs exceptions: The problem with both is that it'll leak security code into core. Though with exceptions there's a workaround with inheriting core classes/interfaces. Which makes Stack's suggestion much more viable.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489824#comment-13489824 ]
Andrew Purtell commented on HBASE-7066:
---------------------------------------
bq. Should we have a marker Interface 'DisallowedException' or a base IOE Exception DisallowedException that ADE implements and then in core we'd check for this
Missed this one. That would be good.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490115#comment-13490115 ]
Lars Hofhansl commented on HBASE-7066:
--------------------------------------
OK... Count me officially confused then. If this exception is never thrown to any client we do not have to throw it, we can have the pre/post methods return false and log whatever we need in the coprocessor hooks.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488215#comment-13488215 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Ted, I did not change the signatures for HMaster in 0.94 as Ram suggested. So that patch should be ok.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489739#comment-13489739 ]
stack commented on HBASE-7066:
------------------------------
Although ADE is from the security package. If we add ADE to the shutdown signature, we are starting to pollute core w/ security. Should we have a marker Interface 'DisallowedException' or a base IOE Exception DisallowedException that ADE implements and then in core we'd check for this ... shutdown would throw this base DisallowedException (There may be a reason other than security violation why a shutdown might be prevented?)
What you think?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487219#comment-13487219 ]
Ted Yu commented on HBASE-7066:
-------------------------------
Looks good. nit:
{code}
+ LOG.error("Error invoking balance", ioe);
{code}
Typo: balance -> balancer.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488363#comment-13488363 ]
Lars Hofhansl commented on HBASE-7066:
--------------------------------------
So what happens when shutdown throws an IOException? Seems shutdown should not fail, no?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7066:
-------------------------------
Attachment: HBASE-7066_trunk.patch
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487854#comment-13487854 ]
stack commented on HBASE-7066:
------------------------------
Previously, if an exception in CPs in say the shutdown method, we would catch it, log it, and then keep going. Now, we let the exception out and skip running the rest of shutdown. As I see it, on shutdown, if exception in CP, we are going to fail the shutdown. Right? This is probably not what we want.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu reassigned HBASE-7066:
----------------------------------
Assignee: Francis Liu
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490057#comment-13490057 ]
Hadoop QA commented on HBASE-7066:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551983/7066-addendum-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 86 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3221//console
This message is automatically generated.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489812#comment-13489812 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Sounds like we need to change the return type from boolean to class to provide a richer response. This would require a large change to the coprocessor framework if we go this route. Can we come up with an interim solution for now?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487526#comment-13487526 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Ted, Fixed the nit.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489704#comment-13489704 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Stack, Good to know, we can do it in increments Master, RS, TokenProvider, etc. Will try and take a look what it would take when I have time.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494158#comment-13494158 ]
Ted Yu commented on HBASE-7066:
-------------------------------
Comment on addendum would be appreciated.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487891#comment-13487891 ]
Ted Yu commented on HBASE-7066:
-------------------------------
If AccessDeniedException is thrown, shutdown would not succeed.
That's the purpose of this JIRA, right ?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489804#comment-13489804 ]
Lars Hofhansl commented on HBASE-7066:
--------------------------------------
Can we instead make the coprocessor protocol be more explicit? I.e. return true from the pre and post hooks means shutdown OK, false from either of these means do not shut down...?
Passing information out of methods via exceptions is always a bit weird.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489646#comment-13489646 ]
Francis Liu commented on HBASE-7066:
------------------------------------
Stack, I see what you're trying to get at, we can have AccessController wrap the exceptions it would have thrown in an AccessDeniedException so it won't get swallowed in shutdown(). The only potential concern here then is the CoprocessorHost messing up though in which case it prolly won't be throwing an IOE so that should acceptable.
Ted, for 0.94 we would have to do some reflection since the Exception is the security module, or actually move the exception. We can't change the signature since that would break backward compatilibity.
Have we ever considered making security first class in 0.96 (not a coprocessor, though still switchable)? More and more it seems to me that security cannot be treated as a bolt-on extension as we have seen handling failures cannot be treated the same way as other extensions. We are already considering changing a public method signature to throw a security exception.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490030#comment-13490030 ]
Ted Yu commented on HBASE-7066:
-------------------------------
The intention of introducing subclass of DoNotRetryIOException is for the scenario where some IO operation in preShutdown() hook causes DoNotRetryIOException to be thrown. We haven't found a case other than authorization failure where shutdown should be skipped.
For 0.94, reflection would be used to enforce similar semantics as in trunk.
Thanks
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7066:
-------------------------------
Attachment: HBASE-7066_94.patch
0.94 backport, I didn't fix the hooks in the balancer() method as this would change the method signature and break backward compatiblity. Let me know if I should.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486538#comment-13486538 ]
Hadoop QA commented on HBASE-7066:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551283/HBASE-7066_94.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3176//console
This message is automatically generated.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489815#comment-13489815 ]
Ted Yu commented on HBASE-7066:
-------------------------------
I concur with Stack's suggestion above @ 02/Nov/12 20:44
AccessDeniedException extends DoNotRetryIOException .
Maybe we can introduce a new exception, CannotIgnoreException, which extends DoNotRetryIOException. Shutdown logic would check whether IOException thrown is an instance of CannotIgnoreException. If it is, shutdown is aborted.
AccessDeniedException would extend CannotIgnoreException.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489668#comment-13489668 ]
stack commented on HBASE-7066:
------------------------------
Regards security as first class citizen rather than as a CP would be good but probably not in scope for 0.96 I'd say. It sounds like a pretty radical refactoring.
Good on you Francis
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487798#comment-13487798 ]
Ted Yu commented on HBASE-7066:
-------------------------------
Integrated to trunk.
Thanks for the patch Francis. Do you want to address Ram's comment about 0.94 patch ?
Thanks for the review, Andy and Ram.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-7066) Some HMaster coprocessor
exceptions are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490052#comment-13490052 ]
Ted Yu edited comment on HBASE-7066 at 11/3/12 4:35 PM:
--------------------------------------------------------
Addendum v2 adds try / catch block for cpHost.preStopMaster().
stopMaster() and shutdown() modified by this JIRA are not in master interface. So the change is compatible.
Once review passes, I can provide patch for 0.94
was (Author: yuzhihong@gmail.com):
Addendum v2 adds try / catch block for cpHost.preStopMaster().
stopMaster() and shutdown() modified by this JIRA are not in master interface. So the change is compatible.
Once review passs, I can provide patch for 0.94
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, 7066-addendum-v2.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490040#comment-13490040 ]
Lars Hofhansl commented on HBASE-7066:
--------------------------------------
What I am saying is that a current 0.94 client does not have that logic (no reflection logic either) so it cannot deal with a new exception being thrown at it.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489939#comment-13489939 ]
Lars Hofhansl commented on HBASE-7066:
--------------------------------------
Hmm... I agree that for security related exception is OK (can be considered an exceptional situation), and also that just return true/false from the coproc does not provide enough information.
CannotIgnoreException could work for 0.96.
For 0.94 it would break old clients on new servers, right? (the old client would not know about CannotIgnoreException).
Another option is to catch and log IOException but to rethrow all HBaseIOExceptions, or maybe just always rethrow DoNotRetryIOException, because the server should not swallow those anyway.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487521#comment-13487521 ]
ramkrishna.s.vasudevan commented on HBASE-7066:
-----------------------------------------------
+1 for trunk patch.
Also i would feel not to change the 0.94 balance(). Because in one of the issues we tried to change it but did not make it as it will result in api change.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489811#comment-13489811 ]
Francis Liu commented on HBASE-7066:
------------------------------------
How will we communicate to the user the reason behind the failure?
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7066:
-------------------------------
Status: Patch Available (was: Open)
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489820#comment-13489820 ]
Andrew Purtell commented on HBASE-7066:
---------------------------------------
bq. Have we ever considered making security first class in 0.96 (not a coprocessor, though still switchable)?
I'm not in favor of this approach unless we want HBASE-6222, specifically the KV labeling part, in which case the changes are so invasive anyway we might as well move everything into core and furthermore reimplement access control on top of labeling.
bq. Change stopMaster() and shutdown() signature with "throws AccessDeniedException"
I think it will be a little weird to have these two methods throw a more specific signature than IOE where everywhere else we have IOE. The larger issue of (ab)use of IOE is a major refactoring. Also, I think AccessDeniedException should remain in the security package until security is otherwise not encapsulated there.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487567#comment-13487567 ]
Hadoop QA commented on HBASE-7066:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551482/HBASE-7066_trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3195//console
This message is automatically generated.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7066:
--------------------------
Attachment: 7066-addendum.txt
Addendum for trunk, demonstrating how master can respond to new exception which cannot be ignored.
Open to better naming.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: 7066-addendum.txt, HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7066:
-------------------------------
Attachment: HBASE-7066_trunk.patch
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions
are being swallowed in try catch blocks
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488098#comment-13488098 ]
Hudson commented on HBASE-7066:
-------------------------------
Integrated in HBase-TRUNK #3501 (See [https://builds.apache.org/job/HBase-TRUNK/3501/])
HBASE-7066 Some HMaster coprocessor exceptions are being swallowed in try catch blocks (Francis Liu) (Revision 1404146)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerChore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira