You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Jacob Perkins (JIRA)" <ji...@apache.org> on 2011/04/21 20:18:05 UTC
[jira] [Created] (PIG-2008) Cache outputFormat in HBaseStorage
Cache outputFormat in HBaseStorage
----------------------------------
Key: PIG-2008
URL: https://issues.apache.org/jira/browse/PIG-2008
Project: Pig
Issue Type: Bug
Components: build
Affects Versions: 0.8.0
Reporter: Jacob Perkins
Priority: Minor
Fix For: 0.8.0
getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028453#comment-13028453 ]
Alan Gates commented on PIG-2008:
---------------------------------
No objections. Unit tests pass. Running test-patch now.
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Jacob Perkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacob Perkins updated PIG-2008:
-------------------------------
Attachment: patch_file.txt
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028841#comment-13028841 ]
Alan Gates commented on PIG-2008:
---------------------------------
Committed to trunk. Will commit to 0.9 branch shortly.
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028380#comment-13028380 ]
Alan Gates commented on PIG-2008:
---------------------------------
Dmitriy, could you take a look at this. It looks ok to me, but I'm not an HBase expert. I'll run the unit tests and such on it.
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028383#comment-13028383 ]
Dmitriy V. Ryaboy commented on PIG-2008:
----------------------------------------
Yeah looks good. Sorry I missed reviewing this earlier.
Alan, objections to committing this to the 0.9 branch? The HTable connection leak is a bug.
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2008) Cache outputFormat in HBaseStorage
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates resolved PIG-2008.
-----------------------------
Resolution: Fixed
Fix Version/s: (was: 0.8.0)
0.10
0.9.0
Assignee: Jacob Perkins
Patch checked into trunk and 0.9 branch. Thanks Jacob.
> Cache outputFormat in HBaseStorage
> ----------------------------------
>
> Key: PIG-2008
> URL: https://issues.apache.org/jira/browse/PIG-2008
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: Jacob Perkins
> Assignee: Jacob Perkins
> Priority: Minor
> Fix For: 0.9.0, 0.10
>
> Attachments: patch_file.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira