[GitHub] [trafficcontrol] jrushford opened a new pull request #5716: ORT plugin_verifier bug fix

[GitBox <gi...@apache.org>]

jrushford opened a new pull request #5716:
URL: https://github.com/apache/trafficcontrol/pull/5716


   
   ## What does this PR (Pull Request) do?
   This fixes a bug in the plugin_verifier so that it does notreport a malformed config when a plugin uses a long option
   parameter in a @pparam field.
   
   - [x] This PR fixes  is not related to any Issue
   
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   
   See the traffic_ops_ort/plugin_verifier/README.md and execute the
   plugin_verifier against a copy of the remap.config which has entries
   for the cachkey.so plugin using long options in its @pparam fields.
   You should not see any errors.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master (b31db7)
   
   ## The following criteria are ALL met by this PR
   
   - [X] This PR includes tests OR I have explained why tests are unnecessary
   - [X] This PR includes documentation OR I have explained why documentation is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [X] This PR includes any and all required license headers
   - [X This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   None
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c commented on pull request #5716: ORT plugin_verifier bug fix

[GitBox <gi...@apache.org>]

rob05c commented on pull request #5716:
URL: https://github.com/apache/trafficcontrol/pull/5716#issuecomment-817187816


   Odd, I thought all checks passed. But it looks like they didn't run at all? Well, I fixed https://github.com/apache/trafficcontrol/pull/5734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c merged pull request #5716: ORT plugin_verifier bug fix

[GitBox <gi...@apache.org>]

rob05c merged pull request #5716:
URL: https://github.com/apache/trafficcontrol/pull/5716


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org