You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/12/17 18:58:54 UTC
Review Request 41520: implementation of AvailablePort.isPortAvailable
for multicast
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41520/
-----------------------------------------------------------
Review request for geode and Jianxia Chen.
Repository: geode
Description
-------
The AvailablePort utility has not had support for finding a free multicast port since feature/GEODE-77 was merged to the develop branch. This change-set enables the old multicast code in AvailablePort and implements the check & response for its datagrams in JGroupsMessenger. The JGroups transport method for receiving packets is overridden to look for these datagrams and respond to them.
I also renamed AvailablePort.JGroups to AvailablePort.MULTICAST, which describes the kind of port that's being tested a little better.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java 1687261030939778a59cf7e3bc948fe92a55e663
gemfire-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java c4907ad0b991d52ad3a52ac0dbe2f1c1b29dec12
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java a3ff8dfdfbd31d5ce06623a9d6dae978981c08ae
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 7d34ab1598c71802b6e3e1d1dd22905c071435ef
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java c84458346d89a8a01a8066753f30c6d2af5215b3
gemfire-core/src/test/java/com/gemstone/gemfire/internal/AvailablePortHelper.java 5230ff9f39aaa1dad9e1a3978345b619ef7f5964
gemfire-core/src/test/java/com/gemstone/gemfire/internal/AvailablePortJUnitTest.java 7244822eb226ae820cfe2db3d485b567115ba9d0
Diff: https://reviews.apache.org/r/41520/diff/
Testing
-------
new unit test, precheckin (underway)
Thanks,
Bruce Schuchardt
Re: Review Request 41520: implementation of
AvailablePort.isPortAvailable for multicast
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41520/#review110992
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On Dec. 17, 2015, 5:58 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41520/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 5:58 p.m.)
>
>
> Review request for geode and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The AvailablePort utility has not had support for finding a free multicast port since feature/GEODE-77 was merged to the develop branch. This change-set enables the old multicast code in AvailablePort and implements the check & response for its datagrams in JGroupsMessenger. The JGroups transport method for receiving packets is overridden to look for these datagrams and respond to them.
>
> I also renamed AvailablePort.JGroups to AvailablePort.MULTICAST, which describes the kind of port that's being tested a little better.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java 1687261030939778a59cf7e3bc948fe92a55e663
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java c4907ad0b991d52ad3a52ac0dbe2f1c1b29dec12
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java a3ff8dfdfbd31d5ce06623a9d6dae978981c08ae
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 7d34ab1598c71802b6e3e1d1dd22905c071435ef
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java c84458346d89a8a01a8066753f30c6d2af5215b3
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/AvailablePortHelper.java 5230ff9f39aaa1dad9e1a3978345b619ef7f5964
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/AvailablePortJUnitTest.java 7244822eb226ae820cfe2db3d485b567115ba9d0
>
> Diff: https://reviews.apache.org/r/41520/diff/
>
>
> Testing
> -------
>
> new unit test, precheckin (underway)
>
>
> Thanks,
>
> Bruce Schuchardt
>
>