You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/07/21 11:10:19 UTC
[GitHub] [openwhisk-runtime-go] falkzoll opened a new pull request #150: Extend `proxy -version` to also show the go runtime version.
falkzoll opened a new pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150
- Extend `proxy -version` to also show the go version the proxy.go was compiled with (makes it easier to check if go security updates need to be applied).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] falkzoll commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
falkzoll commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674159000
##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
// show version number
if *version {
- fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+ fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())
Review comment:
Ok, then I will leave it as it is 👍 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674299436
##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
// show version number
if *version {
- fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+ fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())
Review comment:
Thanks for the disambiguation of printed output and the string already having 'go` as it was not clear when I commented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674000695
##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
// show version number
if *version {
- fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+ fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())
Review comment:
"built with Go runtime version"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] falkzoll commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
falkzoll commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674140856
##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
// show version number
if *version {
- fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+ fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())
Review comment:
Right now I did not mention `Go runtime version` in the string as the string returned by runtime.version() already contains a leading 'go'.
```
OpenWhisk ActionLoop Proxy v1.17.1, built with go1.15.3
```
With the proposed change it will look like this:
```
OpenWhisk ActionLoop Proxy v1.17.1, built with Go runtime version go1.15.3
```
Optionally the double `go` in the output can be avoided:
```
OpenWhisk ActionLoop Proxy v1.17.1, built with go1.15.3 runtime
```
What do you think?
I will then change the message accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows merged pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on a change in pull request #150: Extend `proxy -version` to also show the go runtime version.
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #150:
URL: https://github.com/apache/openwhisk-runtime-go/pull/150#discussion_r674146056
##########
File path: main/proxy.go
##########
@@ -49,7 +50,7 @@ func main() {
// show version number
if *version {
- fmt.Printf("OpenWhisk ActionLoop Proxy v%s\n", openwhisk.Version)
+ fmt.Printf("OpenWhisk ActionLoop Proxy v%s, built with %s\n", openwhisk.Version, runtime.Version())
Review comment:
my 2 cents is the original message (`OpenWhisk ActionLoop Proxy v1.17.1, built with go1.15.3`) is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org