You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/13 04:48:11 UTC

[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #981: Replace constant macros to constexpr variables and enums in headers

tanruixiang commented on PR #981:
URL: https://github.com/apache/incubator-kvrocks/pull/981#issuecomment-1277027541

   Hi. Is it better to use `constexpr` here too?
   https://github.com/apache/incubator-kvrocks/blob/unstable/src/redis_cmd.cc#L63


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org