[jira] [Work logged] (BEAM-12856) Allow for configuration of unbounded reader max elements, read time etc in StreamingDataflowRunner

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12856?focusedWorklogId=661846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661846 ]

ASF GitHub Bot logged work on BEAM-12856:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Oct/21 18:50
            Start Date: 07/Oct/21 18:50
    Worklog Time Spent: 10m 
      Work Description: JayDosunmu commented on a change in pull request #15478:
URL: https://github.com/apache/beam/pull/15478#discussion_r724445775



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java
##########
@@ -230,6 +230,28 @@ public Dataflow create(PipelineOptions options) {
 
   void setReaderCacheTimeoutSec(Integer value);
 
+  /** The max amount of time an UnboundedReader is consumed before checkpointing. */
+  @Description(
+      "The max amount of time before an UnboundedReader is consumed before checkpointing, in seconds.")
+  @Default.Integer(10)
+  Integer getUnboundedReaderMaxReadTimeSec();
+
+  void setUnboundedReaderMaxReadTimeSec(Integer value);
+
+  /** The max elements read from an UnboundedReader before checkpointing. */
+  @Description("The max elements read from an UnboundedReader before checkpointing. ")
+  @Default.Integer(10 * 1000)

Review comment:
       @scwhittle Just a heads up, in Java, you can use underscores in numbers i.e. 10_000. This may be useful in the future




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 661846)
    Time Spent: 1h 50m  (was: 1h 40m)

> Allow for configuration of unbounded reader max elements, read time etc in StreamingDataflowRunner
> --------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-12856
>                 URL: https://issues.apache.org/jira/browse/BEAM-12856
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Sam Whittle
>            Assignee: Sam Whittle
>            Priority: P2
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently in WorkerCustomSources.java it is hard-coded to 10 seconds, 10k elements, with 1sec waiting for elements if none are available.
> There are cases where it would be beneficial to wait longer and process more data so it would be nice if this was controlled by pipeline option.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)