You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 14:04:08 UTC
[GitHub] [arrow] pitrou opened a new pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
pitrou opened a new pull request #7178:
URL: https://github.com/apache/arrow/pull/7178
- Allow same-scale casts
- Detect truncation when target precision is too small
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629007132
The rebase headache of this should not be good bad, FWIW. Working furiously to refactor things...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-638982348
@wesm Would you like to validate the codegen additions here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629007132
The rebase headache of this should not be too bad, FWIW. Working furiously to refactor things...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7178:
URL: https://github.com/apache/arrow/pull/7178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-637572226
I'm rebasing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-628666137
https://issues.apache.org/jira/browse/ARROW-8568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629197677
Woops, sorry, I had forgotten about the refactor. But, yeah, the changes are quite localized here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-638983527
Yes will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629210514
No problem. I've been burning the midnight oil this week so it shouldn't delay too much longer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org