You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by pe...@apache.org on 2012/04/07 10:51:44 UTC

svn commit: r1310707 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

Author: pero
Date: Sat Apr  7 08:51:44 2012
New Revision: 1310707

URL: http://svn.apache.org/viewvc?rev=1310707&view=rev
Log:
Send header with uppercase names

Modified:
    tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

Modified: tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java?rev=1310707&r1=1310706&r2=1310707&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java Sat Apr  7 08:51:44 2012
@@ -102,8 +102,8 @@ public abstract class WebSocketServlet e
         //      data present when the frame is fragmented.
 
         // If we got this far, all is good. Accept the connection.
-        resp.setHeader("upgrade", "websocket");
-        resp.setHeader("connection", "upgrade");
+        resp.setHeader("Upgrade", "websocket");
+        resp.setHeader("Connection", "upgrade");
         resp.setHeader("Sec-WebSocket-Accept", getWebSocketAccept(key));
         if (subProtocol != null) {
             resp.setHeader("Sec-WebSocket-Protocol", subProtocol);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1310707 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

Posted by Peter Roßbach <pr...@objektpark.de>.
Yes, but most Http-Header send with first uppercase letter.

is a cosmetic fix :-)

Peter

Am 07.04.2012 um 10:53 schrieb Mark Thomas:

> On 07/04/2012 09:51, pero@apache.org wrote:
>> Author: pero
>> Date: Sat Apr  7 08:51:44 2012
>> New Revision: 1310707
>> 
>> URL: http://svn.apache.org/viewvc?rev=1310707&view=rev
>> Log:
>> Send header with uppercase names
> 
> Why? HTTP headers are case insensitive.
> 
> Mark
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1310707 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

Posted by Mark Thomas <ma...@apache.org>.
On 07/04/2012 09:51, pero@apache.org wrote:
> Author: pero
> Date: Sat Apr  7 08:51:44 2012
> New Revision: 1310707
> 
> URL: http://svn.apache.org/viewvc?rev=1310707&view=rev
> Log:
> Send header with uppercase names

Why? HTTP headers are case insensitive.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org