[GitHub] [druid] suneet-s commented on pull request #11184: vectorize logical operators and boolean functions

[GitBox <gi...@apache.org>]

suneet-s commented on pull request #11184:
URL: https://github.com/apache/druid/pull/11184#issuecomment-880327567


   I tested what calcite does if you just issue a select statement in the web-console, and it's behavior is similar to what is spelt out in the PR description. I'm in agreement with the behavior change in the description. The one thing I did notice is that calcite treats `'true'` and `true` differently. NOTE to self: check for this subtle difference 
   `SELECT 'true' || null` returns `'true'`
   `SELECT true || null` returns `1`
   
   The feature flag does seem like the only option since this change does affect query results. I am reading through the code now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org