You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/04/08 04:18:28 UTC
[PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
beliefer opened a new pull request, #26418:
URL: https://github.com/apache/flink/pull/26418
## What is the purpose of the change
This PR aims to unify the name for the collection of `SlotOffer`.
Currently, there are two name of variable about collection of `SlotOffer`. One is `slots` and another is `offers`.
I think `slotOffers` have better readability than them.
## Brief change log
Unify the name for the collection of `SlotOffer` with `slotOffers`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26418:
URL: https://github.com/apache/flink/pull/26418#issuecomment-4369005565
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26418:
URL: https://github.com/apache/flink/pull/26418#issuecomment-4610280129
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26418:
URL: https://github.com/apache/flink/pull/26418#issuecomment-2785194374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43a54812fb035d279a21137de5f65d667500142d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43a54812fb035d279a21137de5f65d667500142d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43a54812fb035d279a21137de5f65d667500142d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26418:
URL: https://github.com/apache/flink/pull/26418#issuecomment-2786228928
ping @KurtYoung @StephanEwen @tillrohrmann cc @1996fanrui @davidradl @GOODBOY008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Unify the name for the collection of SlotOffer with slotOffers [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26418: [hotfix] Unify the name for the collection of SlotOffer with slotOffers
URL: https://github.com/apache/flink/pull/26418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org