You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/01/18 06:35:53 UTC
[GitHub] [james-project] chibenwa commented on a change in pull request #847: JAMES-3680 Docker-compose example for IMAP/SMTP OIDC
chibenwa commented on a change in pull request #847:
URL: https://github.com/apache/james-project/pull/847#discussion_r786448601
##########
File path: examples/oidc/james/imapserver.xml
##########
@@ -0,0 +1,73 @@
+<?xml version="1.0"?>
+<imapservers>
+ <imapserver enabled="true">
+ <jmxName>imapserver</jmxName>
+ <bind>0.0.0.0:143</bind>
+ <connectionBacklog>200</connectionBacklog>
+ <tls socketTLS="false" startTLS="false">
+ <!-- To create a new keystore execute:
+ keytool -genkey -alias james -keyalg RSA -storetype PKCS12 -keystore /path/to/james/conf/keystore
+ -->
Review comment:
Remove comments here and everywhere.
##########
File path: examples/oidc/james/imapserver.xml
##########
@@ -0,0 +1,73 @@
+<?xml version="1.0"?>
+<imapservers>
+ <imapserver enabled="true">
+ <jmxName>imapserver</jmxName>
+ <bind>0.0.0.0:143</bind>
Review comment:
Can we just remove the startTLS endpoints and just keep the SSL endpoints? (IMAP & SMTP)
##########
File path: examples/oidc/james/jmap.properties
##########
@@ -17,7 +17,7 @@ tls.secret=james72laBalle
# The following entry specify the link to the URL of the public key file,
# which should be a PEM format file.
#
-#jwt.publickeypem.url=file://conf/jwt_publickey
+jwt.publickeypem.url=file://conf/jwt_publickey
Review comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org