You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/03/14 12:14:07 UTC
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/6
Ensure explicit use of bash
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-client build-break-work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-client/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit f26f35bf70c01d8d3f3b1bbfa25c473284400912
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-14T11:10:45Z
Ensure explicit use of bash
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196288933
closing to re-open to catch up with a8fa7fb and a0b58de
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-client/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196373019
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196317176
Good point @rdowner. Agree that most users which install go just for the build (including me) won't have the path set.
On the other hand `GOPATH` is being set, but after being used at the beginning - is this intentional @geomacy?
Let's merge this one so we have the client building without errors and address it in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196293852
re-opening
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy closed the pull request at:
https://github.com/apache/brooklyn-client/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
GitHub user geomacy reopened a pull request:
https://github.com/apache/brooklyn-client/pull/6
Ensure explicit use of bash
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-client build-break-work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-client/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit f26f35bf70c01d8d3f3b1bbfa25c473284400912
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-14T11:10:45Z
Ensure explicit use of bash
commit a8fa7fb3b112ccfde9d7c402918bca395f096aa7
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-14T11:32:50Z
Fix typo
commit a0b58de5fa4e7477463b8cd6d785996f2109a21f
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-03-14T11:44:19Z
Add recursive listing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196321059
The way I have it at the moment is to try to make the package simultaneously be
1. A regular Go module that expects to be built within the usual GOPATH structure, and
2. A regular Maven module that can be cloned and built at any arbitrary location
to do this, I have set up the Maven build to ignore any pre-existing GOPATH and to redefine GOPATH itself, pointing at the target directory. That way you can do a Maven build without worrying about what's on your GOPATH or whether you even have one (for developers who don't care about Go - of course you do still need Go itself installed, but you don't need to think about setting up a Go workspace etc.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196288972
re-opening
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196370946
@rdowner `GOPATH` addressed in https://github.com/apache/brooklyn-client/pull/7. Now it's exlpicitly set, relative to the build folder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Ensure explicit use of bash
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/brooklyn-client/pull/6#issuecomment-196314801
My system does not have the `GOPATH` variable set. Despite this, this module seems to build OK. Does this mean that - (option A) my environment is misconfigured and something will break at some point in the future, or (option B) that we don't actually need to reference `GOPATH`?
I did notice from the link in README.md that `GOPATH` is a *list* of paths separated by (semi)colons. I see this line in the script:
```bash
EXECUTABLE_DIR="$GOPATH/src/$GOPACKAGE"
```
...which would seem to break if `GOPATH` does indeed contain a list of paths.
(If I'm going offtopic for this PR then just say, and I'll make a new JIRA for it instead.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---