You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/11/10 11:55:09 UTC

[GitHub] tinkerpop pull request #746: TINKERPOP-1829 Made detachment configurable in ...

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/746

    TINKERPOP-1829 Made detachment configurable in EventStrategy

    https://issues.apache.org/jira/browse/TINKERPOP-1831
    
    The default behavior is representative of how EventStrategy currently works so there is no breaking change here. In the interest of avoiding breaking changes, I didn't want to shift the API to make the change cleaner and thus created TINKERPOP-1831 for future consideration.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1829

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #746
    
----
commit a5f48d91069d10fe8abdcbb0559315bae10ead5f
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-11-10T11:46:10Z

    TINKERPOP-1829 Made detachment configurable in EventStrategy
    
    The default behavior is representative of how EventStrategy currently works so there is no breaking change here. In the interest of avoiding breaking changes, I didn't want to shift the API to make the change cleaner and thus created TINKERPOP-1831 for future consideration.

----


---

[GitHub] tinkerpop issue #746: TINKERPOP-1829 Made detachment configurable in EventSt...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/746
  
    VOTE: +1


---

[GitHub] tinkerpop issue #746: TINKERPOP-1829 Made detachment configurable in EventSt...

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/746
  
    VOTE +1


---

[GitHub] tinkerpop pull request #746: TINKERPOP-1829 Made detachment configurable in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/746


---