You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/29 04:50:29 UTC
[PR] ci: require 60% patch coverage in Codecov [texera]
Yicong-Huang opened a new pull request, #6022:
URL: https://github.com/apache/texera/pull/6022
### What changes were proposed in this PR?
The Codecov patch status was `informational: true`, so it never gated PRs. This makes it a real requirement:
- set `target: 60%` on `coverage.status.patch.default`;
- drop the `informational` flag so the patch check can fail.
PRs must now cover at least 60% of the lines they change. Project status (auto target, 1% threshold), flag carryforward, and ignore rules are unchanged. The explanatory comment in `codecov.yml` is updated to match.
### Any related issues, documentation, discussions?
Closes #6021
### How was this PR tested?
Config-only change; `codecov.yml` validated as well-formed YAML. Codecov applies the new policy on the next PR upload.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #6022:
URL: https://github.com/apache/texera/pull/6022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6022:
URL: https://github.com/apache/texera/pull/6022#discussion_r3489650785
##########
codecov.yml:
##########
@@ -68,10 +68,14 @@ coverage:
threshold: 1%
patch:
default:
- # Surface patch coverage in the Codecov report but don't gate
- # PRs on it: a 100%-patch policy blocks plenty of legitimate
- # refactors / config-only changes that have no tests to add.
- informational: true
+ # Require new/changed lines in a PR to be at least 60% covered.
+ # Lower than a 100%-patch policy so legitimate refactors and
+ # config-only changes aren't blocked, but high enough that net-new
+ # code ships with tests. The 10% threshold softens the quantization
+ # on tiny diffs (e.g. a 2-coverable-line change passes at 1 line /
+ # 50%) — patch passes when coverage is >= target - threshold = 50%.
+ target: 60%
+ threshold: 10%
Review Comment:
Linked issue #6021 (and the earlier header comment) reads as “require 60% patch coverage”. With `target: 60%` plus `threshold: 10%`, the effective pass floor becomes 50% (as your own comment notes), so this no longer enforces a 60% minimum. If the intent is a hard 60% gate, drop the threshold (or set it to 0%) and remove the quantization explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6022:
URL: https://github.com/apache/texera/pull/6022#issuecomment-4829096260
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #6022:
URL: https://github.com/apache/texera/pull/6022#discussion_r3489662446
##########
codecov.yml:
##########
@@ -68,10 +68,14 @@ coverage:
threshold: 1%
patch:
default:
- # Surface patch coverage in the Codecov report but don't gate
- # PRs on it: a 100%-patch policy blocks plenty of legitimate
- # refactors / config-only changes that have no tests to add.
- informational: true
+ # Require new/changed lines in a PR to be at least 60% covered.
+ # Lower than a 100%-patch policy so legitimate refactors and
+ # config-only changes aren't blocked, but high enough that net-new
+ # code ships with tests. The 10% threshold softens the quantization
+ # on tiny diffs (e.g. a 2-coverable-line change passes at 1 line /
+ # 50%) — patch passes when coverage is >= target - threshold = 50%.
+ target: 60%
+ threshold: 10%
Review Comment:
intended to be softer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6022:
URL: https://github.com/apache/texera/pull/6022#issuecomment-4829099146
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6022?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.64%. Comparing base ([`16a3ddf`](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0e66827`](https://app.codecov.io/gh/apache/texera/commit/0e66827ab846f1259aa7e1b33090c2082c1659b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6022 +/- ##
=========================================
Coverage 56.64% 56.64%
Complexity 3028 3028
=========================================
Files 1124 1124
Lines 43298 43298
Branches 4667 4667
=========================================
Hits 24525 24525
Misses 17335 17335
Partials 1438 1438
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.62% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.39% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [16a3ddf](https://app.codecov.io/gh/apache/texera/commit/16a3ddfe58fd7540d8ab5c9da88f0901cb804f4d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6022?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: require 60% patch coverage in Codecov [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6022:
URL: https://github.com/apache/texera/pull/6022#issuecomment-4829118367
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 4 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `16a3ddf` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28349379473)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 390 | 0.238 | 24,041/35,859/35,859 us | 🔴 +14.3% / 🔴 +133.9% |
| 🟢 | bs=100 sw=10 sl=64 | 827 | 0.505 | 119,589/144,208/144,208 us | 🟢 -8.8% / 🔴 +30.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 926 | 0.565 | 1,079,805/1,135,503/1,135,503 us | ⚪ within ±5% / 🔴 +6.7% |
<details><summary>Baseline details</summary>
Latest main `16a3ddf` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 390 tuples/sec | 426 tuples/sec | 757.16 tuples/sec | -8.5% | -48.5% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.26 MB/s | 0.462 MB/s | -8.5% | -48.5% |
| bs=10 sw=10 sl=64 | p50 | 24,041 us | 24,224 us | 12,971 us | -0.8% | +85.3% |
| bs=10 sw=10 sl=64 | p95 | 35,859 us | 31,361 us | 15,333 us | +14.3% | +133.9% |
| bs=10 sw=10 sl=64 | p99 | 35,859 us | 31,361 us | 18,732 us | +14.3% | +91.4% |
| bs=100 sw=10 sl=64 | throughput | 827 tuples/sec | 831 tuples/sec | 957.66 tuples/sec | -0.5% | -13.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.505 MB/s | 0.507 MB/s | 0.585 MB/s | -0.4% | -13.6% |
| bs=100 sw=10 sl=64 | p50 | 119,589 us | 118,475 us | 103,982 us | +0.9% | +15.0% |
| bs=100 sw=10 sl=64 | p95 | 144,208 us | 158,050 us | 110,583 us | -8.8% | +30.4% |
| bs=100 sw=10 sl=64 | p99 | 144,208 us | 158,050 us | 118,369 us | -8.8% | +21.8% |
| bs=1000 sw=10 sl=64 | throughput | 926 tuples/sec | 937 tuples/sec | 979.6 tuples/sec | -1.2% | -5.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.565 MB/s | 0.572 MB/s | 0.598 MB/s | -1.2% | -5.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,079,805 us | 1,062,296 us | 1,024,553 us | +1.6% | +5.4% |
| bs=1000 sw=10 sl=64 | p95 | 1,135,503 us | 1,097,686 us | 1,063,789 us | +3.4% | +6.7% |
| bs=1000 sw=10 sl=64 | p99 | 1,135,503 us | 1,097,686 us | 1,096,239 us | +3.4% | +3.6% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.85,200,128000,390,0.238,24041.20,35859.32,35859.32
1,100,10,64,20,2418.20,2000,1280000,827,0.505,119589.18,144208.23,144208.23
2,1000,10,64,20,21602.97,20000,12800000,926,0.565,1079804.90,1135503.31,1135503.31
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org