You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/12 11:38:46 UTC

[GitHub] [incubator-doris] wangbo commented on a diff in pull request #8967: [optimize](storage)optimize date in storage layer

wangbo commented on code in PR #8967:
URL: https://github.com/apache/incubator-doris/pull/8967#discussion_r848334514


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -205,13 +218,30 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
         }
     }
 
+    void insert_many_date(const char* data_ptr, size_t num) {
+        size_t intput_type_size  = sizeof(uint24_t);
+        size_t res_type_size = sizeof(uint32_t);
+        char* input_data_ptr = const_cast<char*>(data_ptr);
+        
+        char* res_ptr = (char*)data.get_end_ptr();
+        memset(res_ptr, 0, res_type_size * num);
+        for (int i = 0; i < num; i++) {

Review Comment:
   ```input_data_ptr``` is a uint24_t array.
   ```res_ptr``` is a uint32_t array.
   The element length is different.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org