[GitHub] [fineract] xurror commented on a change in pull request #1218: FINERACT-1098 - Catch JpaSystemException in jpa transactions

[GitBox <gi...@apache.org>]

xurror commented on a change in pull request #1218:
URL: https://github.com/apache/fineract/pull/1218#discussion_r464361531



##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/closure/service/GLClosureWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -142,8 +144,7 @@ public CommandProcessingResult deleteGLClosure(final Long glClosureId) {
      * @param command
      * @param dve
      */
-    private void handleGLClosureIntegrityIssues(final JsonCommand command, final DataIntegrityViolationException dve) {
-        final Throwable realCause = dve.getMostSpecificCause();
+    private void handleGLClosureIntegrityIssues(final JsonCommand command, final Throwable realCause, final Exception dve) {

Review comment:
       @vorburger instead NestedRuntimeException I used NonTransientDataAccessException which is a more suited super class.
   You can check this and if it's LGTY you can merge.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org