You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/08/17 07:26:24 UTC
[GitHub] [incubator-hugegraph-toolchain] BestBurning opened a new pull request, #326: fix: Line fetch some value null
BestBurning opened a new pull request, #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326
fix: Line fetch some value null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#issuecomment-1277787271
Looks the same as PR https://github.com/apache/incubator-hugegraph-toolchain/pull/321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#issuecomment-1217652508
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#326](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/326?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09f6825) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/278fbea3355d1dbdfee6861c146b6be47a40bf64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (278fbea) will **decrease** coverage by `0.06%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #326 +/- ##
============================================
- Coverage 67.49% 67.42% -0.07%
- Complexity 877 878 +1
============================================
Files 86 86
Lines 4024 4031 +7
Branches 475 475
============================================
+ Hits 2716 2718 +2
- Misses 1104 1108 +4
- Partials 204 205 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gegraph/loader/reader/file/OrcFileLineFetcher.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3JlYWRlci9maWxlL09yY0ZpbGVMaW5lRmV0Y2hlci5qYXZh) | `83.60% <50.00%> (-7.14%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#discussion_r958616288
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/file/OrcFileLineFetcher.java:
##########
@@ -123,11 +123,18 @@ public Line fetch() throws IOException {
if (!this.recordReader.hasNext()) {
return null;
}
-
+ Object[] values = null;
this.row = this.recordReader.next(this.row);
- Object[] values = this.inspector.getStructFieldsDataAsList(this.row)
- .stream().map(Object::toString)
- .toArray();
+ try {
+ values = this.inspector.getStructFieldsDataAsList(this.row)
+ .stream()
+ .map(o -> o != null ? o.toString() : "")
+ .toArray();
+ } catch (NullPointerException e) {
Review Comment:
I think it won't throw NullPointerException if we translated null to "", right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin closed pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
imbajin closed pull request #326: fix: Line fetch some value null
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] coderzc commented on a diff in pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#discussion_r957307696
##########
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/file/OrcFileLineFetcher.java:
##########
@@ -123,11 +123,18 @@ public Line fetch() throws IOException {
if (!this.recordReader.hasNext()) {
return null;
}
-
+ Object[] values = null;
this.row = this.recordReader.next(this.row);
- Object[] values = this.inspector.getStructFieldsDataAsList(this.row)
- .stream().map(Object::toString)
- .toArray();
+ try {
+ values = this.inspector.getStructFieldsDataAsList(this.row)
+ .stream()
+ .map(o -> o != null ? o.toString() : "")
Review Comment:
Filter null value？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] github-actions[bot] commented on pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#issuecomment-1262810668
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #326: fix: Line fetch some value null
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #326:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/326#issuecomment-1299695624
close it since no update for long time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org